Plane: is_landing to use mission_landing_seq #24141
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think the landing sequence flag is close enough to a landing to count. A landing sequence does not even have to end in a landing. |
tridge
requested changes
Jun 27, 2023
| @@ -162,5 +162,5 @@ bool ModeAuto::_pre_arm_checks(size_t buflen, char *buffer) const | |||
|
|
|||
| bool ModeAuto::is_landing() const | |||
| { | |||
| return (plane.flight_stage == AP_FixedWing::FlightStage::LAND); | |||
| return (plane.flight_stage == AP_FixedWing::FlightStage::LAND) || (plane.mission.get_in_landing_sequence_flag()); | |||
There was a problem hiding this comment.
a in landing sequence binding makes more sense I think
There was a problem hiding this comment.
a in landing sequence binding makes more sense I think
Yes that makes more sense. I was struggling with a binding for is_landingIO where the inverse may not be !in_landing(). i.e if you wrote "not is_landing()" in your script or had an "if is_landing() .. else ..." you might not get what you expect. This is better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plane's AP_Vehicle()->is_landing() to also check if the mission thinks it's landing soon.
This is a follow-up from PR #24021