New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AP_Camera: add CAMx_OPTION support for start/stop recording when arm/Disarm #24193

Merged

tridge merged 1 commit into ArduPilot:master from khanasif786:camx_option

Jul 4, 2023

Contributor

khanasif786 commented Jul 2, 2023 •

edited

Tested on SiYI zr10.

IamPete1 reviewed

View reviewed changes

libraries/AP_Camera/AP_Camera_Backend.cpp Outdated Show resolved Hide resolved

IamPete1 reviewed

View reviewed changes

libraries/AP_Camera/AP_Camera_Backend.h Outdated Show resolved Hide resolved

IamPete1 reviewed

View reviewed changes

libraries/AP_Camera/AP_Camera_MAVLinkCamV2.cpp Outdated Show resolved Hide resolved

IamPete1 reviewed

View reviewed changes

libraries/AP_Camera/AP_Camera_Mount.cpp Outdated Show resolved Hide resolved

IamPete1 reviewed

View reviewed changes

libraries/AP_Camera/AP_Camera_Scripting.cpp Outdated Show resolved Hide resolved

Contributor Author

khanasif786 commented Jul 2, 2023 •

edited

I think you should let this one past, blocking this means that if the camera recording ever gets of of sync with what AP is expecting we can't fix it.

@IamPete1 Thanks for the suggestions. Well the problem with not blocking is that ( atleast what i see in my case in SiYi zr10) if we don't block then It sends recording message to camera again and again that causes camera record 0bytes mp4 files. May be it is due to the fact that SiYi has same message(command) to start and stop video recording. So every time we arm it causes multiple 0Bytes files to write in the memory in those not a single one is playable.

rmackay9 reviewed

View reviewed changes

libraries/AP_Camera/AP_Camera_Backend.cpp Outdated Show resolved Hide resolved

rmackay9 reviewed

View reviewed changes

libraries/AP_Camera/AP_Camera_MAVLinkCamV2.cpp Outdated Show resolved Hide resolved

rmackay9 reviewed

View reviewed changes

libraries/AP_Camera/AP_Camera_Backend.cpp Outdated Show resolved Hide resolved

khanasif786 force-pushed the camx_option branch from bf03688 to b6059d7 Compare

July 3, 2023 07:33

Contributor Author

khanasif786 commented Jul 3, 2023

@rmackay9 I think instead of values we should use a bitmask so in future adding more options will be easier.

Contributor

rmackay9 commented Jul 3, 2023

Great, this is much better thanks.

Can you fix the commit message to start with "AP_Camera:"?

rmackay9 reviewed

View reviewed changes

libraries/AP_Camera/AP_Camera_Backend.cpp Outdated Show resolved Hide resolved

rmackay9 approved these changes

View reviewed changes

khanasif786 force-pushed the camx_option branch from b6059d7 to 156cc49 Compare

July 3, 2023 08:25

Contributor Author

khanasif786 commented Jul 3, 2023

@rmackay9 I think instead of values we should use a bitmask so in future adding more options will be easier.

The required changes for this also done.

Contributor

rmackay9 commented Jul 3, 2023

Great, thanks very much for this.

This has been tested to confirm that the ZR10 attempts to start and stop recording when the autopilot is armed/disarmed? I'm sure you have but I just want to check before we merge.

Contributor Author

khanasif786 commented Jul 3, 2023 •

edited

@rmackay9 Yeah Tested on Zr10.

rmackay9 added Enhancement MergeOnCIPass labels

Hwurzburg added the WikiNeeded label


          AP_Camera: add CAMx_OPTION support for start/stop recording when arm/…

59be324

…Disarm

khanasif786 force-pushed the camx_option branch from 156cc49 to 59be324 Compare

July 3, 2023 18:00

tridge merged commit 82b7090 into ArduPilot:master

79 of 81 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment