Fixed formula in AP_L1_Control::nav_roll_cd #24331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @abaghiyan, Thanks for this. Can you modify the commit description (not the PR description) to start with, "AP_L1_Control: "? We like to have the subsystem/directory on the front of each commit because it makes backporting easier. |
|
Can you rebase on master? We need to get rid of that merge commit. |
tridge
previously requested changes
Jul 19, 2023
|
@priseborough can you check? |
Thank you for comments, rebased. |
abaghiyan
force-pushed
the
formulalfix
branch
2 times, most recently
from
8243ddf
to
d23a472
Compare
See details here: ArduPilot#24319
According suggestion from Andrew Tridgell: ArduPilot#24331 (comment)
IamPete1
approved these changes
Jul 26, 2023
117-MasterChief
pushed a commit
to 117-MasterChief/ardupilot
that referenced
this pull request
Aug 5, 2023
According suggestion from Andrew Tridgell: ArduPilot#24331 (comment)
KosmX
pushed a commit
to KosmX/ardupilot
that referenced
this pull request
Aug 21, 2023
According suggestion from Andrew Tridgell: ArduPilot#24331 (comment)
KosmX
pushed a commit
to KosmX/ardupilot
that referenced
this pull request
Aug 21, 2023
According suggestion from Andrew Tridgell: ArduPilot#24331 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See details here: #24319