New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AP_Camera: add support for the user to specify which gimbal each camera is in #24398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmackay9
reviewed
Jul 26, 2023
rmackay9
reviewed
Jul 26, 2023
rmackay9
reviewed
Jul 26, 2023
rmackay9
reviewed
Jul 26, 2023
rmackay9
reviewed
Jul 26, 2023
I've put some comments in but this all looks very good to me, thanks! |
khanasif786
force-pushed
the
mnt_cam_instance
branch
from
July 26, 2023 07:16
f5efa4b
to
53a35d8
Compare
IamPete1
reviewed
Jul 26, 2023
khanasif786
force-pushed
the
mnt_cam_instance
branch
from
July 26, 2023 19:00
53a35d8
to
15a5986
Compare
rmackay9
reviewed
Jul 26, 2023
khanasif786
force-pushed
the
mnt_cam_instance
branch
from
July 27, 2023 06:24
fea369f
to
a68376c
Compare
I did a search through AP_Camera for, "mount->" and found that we've probably missed:
|
khanasif786
force-pushed
the
mnt_cam_instance
branch
from
August 1, 2023 19:25
a68376c
to
e1430a7
Compare
rmackay9
reviewed
Aug 2, 2023
Looking good! |
khanasif786
force-pushed
the
mnt_cam_instance
branch
from
August 2, 2023 20:15
e1430a7
to
31cd699
Compare
peterbarker
reviewed
Aug 3, 2023
peterbarker
reviewed
Aug 3, 2023
peterbarker
previously requested changes
Aug 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of things to fix in stand-alone comments.
khanasif786
force-pushed
the
mnt_cam_instance
branch
from
August 3, 2023 09:57
31cd699
to
a961945
Compare
…rresponding mount
…using multiple gimbals
khanasif786
force-pushed
the
mnt_cam_instance
branch
from
August 3, 2023 10:04
a961945
to
deda808
Compare
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new parameter, CAMx_MNT_INST to allow users to specify which mount the camera is in. This is useful in numerous situations including allowing the correct mount angles to be logged at the moment a picture is taken.