Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_Camera: add support for the user to specify which gimbal each camera is in #24398

Merged
merged 4 commits into from Aug 9, 2023

Conversation

khanasif786
Copy link
Contributor

@khanasif786 khanasif786 commented Jul 26, 2023

This adds a new parameter, CAMx_MNT_INST to allow users to specify which mount the camera is in. This is useful in numerous situations including allowing the correct mount angles to be logged at the moment a picture is taken.

@khanasif786 khanasif786 marked this pull request as draft July 26, 2023 05:11
@rmackay9
Copy link
Contributor

I've put some comments in but this all looks very good to me, thanks!

@khanasif786 khanasif786 marked this pull request as ready for review July 26, 2023 07:16
@khanasif786 khanasif786 marked this pull request as draft July 26, 2023 07:19
@Hwurzburg Hwurzburg added the WikiNeeded needs wiki update label Jul 26, 2023
@rmackay9 rmackay9 marked this pull request as ready for review July 27, 2023 06:55
@rmackay9
Copy link
Contributor

I did a search through AP_Camera for, "mount->" and found that we've probably missed:

  • AP_Camera_Backend::Write_CameraInfo() uses the ca,era instance when it should use the newly added method
  • send_camera_information() and send_camera_settings() seem to send for all mounts which doesn't seem correct. Surely this should only be sending for one instance (this seems like my mistake, sorry!)

@rmackay9
Copy link
Contributor

rmackay9 commented Aug 2, 2023

Looking good!

Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of things to fix in stand-alone comments.

@rmackay9 rmackay9 dismissed peterbarker’s stale review August 9, 2023 00:08

PeterB's issues address I think.

@rmackay9 rmackay9 merged commit f26528e into ArduPilot:master Aug 9, 2023
81 checks passed
@rmackay9
Copy link
Contributor

rmackay9 commented Aug 9, 2023

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants