AP_Mount: fix SiYi doesn't zoom continuously while manual zoom control #24639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmackay9
reviewed
Aug 17, 2023
khanasif786
force-pushed
the
zoom_bug
branch
6 times, most recently
from
fedeac0
to
36d930a
Compare
|
I think CI shouldn't fail now. @rmackay9 Could you please review this again. |
khanasif786
force-pushed
the
zoom_bug
branch
2 times, most recently
from
dc0b1ee
to
724f03c
Compare
|
Updated on top of my changes as suggested on discord. |
2 tasks
khanasif786
force-pushed
the
zoom_bug
branch
4 times, most recently
from
ffd6ec6
to
7eb50a9
Compare
rmackay9
approved these changes
Aug 24, 2023
There was a problem hiding this comment.
LGTM thanks.
I've tested this quite a bit on my A8 and ZR10. The absolute zoom doesn't work on my ZR10 but it does apparently work on @khanasif786's ZR10.
khanasif786
force-pushed
the
zoom_bug
branch
4 times, most recently
from
385a7bf
to
306a92f
Compare
|
changed according to @peterbarker suggestion for using a structure. |
Co-authored-by: Randy Mackay <rmackay9@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While sending a Manual zoom (rate) command to SiYi. zoom stops multiple time in between. This Pull fixes this by sending the same command multiple time at 20Hz. Tested on Zr10.
Support issue link here
I find out one more bug that is probably SiYI side. that is when we watch the zoom value on the SiYI FPV app the values are different than real zoom. eg: on 30x sometime it tell 20x, 22x, 27x etc.