Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tools : Added custom ROS-2 service definition for switching drive modes #24705

Merged
merged 1 commit into from Sep 1, 2023
Merged

Tools : Added custom ROS-2 service definition for switching drive modes #24705

merged 1 commit into from Sep 1, 2023

Conversation

arshPratap
Copy link
Member

Added custom ROS-2 service definition for switching drive modes.
Service definition used from here
@Ryanf55 @srmainwaring @tridge

@arshPratap arshPratap mentioned this pull request Aug 19, 2023
Merged
Ryanf55
Ryanf55 requested changes Aug 19, 2023
View reviewed changes
Tools/ros2/ardupilot_msgs/srv/ModeSwitch.srv Outdated Show resolved Hide resolved
Tools/ros2/ardupilot_msgs/srv/ModeSwitch.srv Outdated Show resolved Hide resolved
srmainwaring
srmainwaring suggested changes Aug 20, 2023
View reviewed changes
Tools/ros2/ardupilot_msgs/srv/ModeSwitch.srv Outdated Show resolved Hide resolved
Tools/ros2/ardupilot_msgs/srv/ModeSwitch.srv Outdated Show resolved Hide resolved
tridge
tridge requested changes Aug 25, 2023
View reviewed changes
Tools/ros2/ardupilot_msgs/srv/ModeSwitch.srv Outdated Show resolved Hide resolved
Tools/ros2/ardupilot_msgs/srv/ModeSwitch.srv Outdated Show resolved Hide resolved
@arshPratap arshPratap force-pushed the modeSwitchSrv branch 2 times, most recently from c838a10 to 30c3281 Compare August 28, 2023 08:12
@arshPratap
Copy link
Member Author

@Ryanf55 @tridge @srmainwaring thanks for the review..have made the changes..Thanks..would like to know your thoughts

@srmainwaring
Copy link
Contributor

@arshPratap - LGTM. You've addressed the issues raised by tridge and Ryan.

@arshPratap arshPratap changed the title Tools : Added custom ROS-2 serivce definition for switching drive modes Tools : Added custom ROS-2 service definition for switching drive modes Aug 28, 2023
@tridge
Copy link
Contributor

tridge commented Aug 29, 2023

@Ryanf55 looks good to me, you OK with the changes?

@tridge
Copy link
Contributor

tridge commented Aug 29, 2023

could use these links:
https://mavlink.io/en/messages/ardupilotmega.html#COPTER_MODE
https://mavlink.io/en/messages/ardupilotmega.html#PLANE_MODE
https://mavlink.io/en/messages/ardupilotmega.html#ROVER_MODE

@arshPratap
Copy link
Member Author

could use these links: https://mavlink.io/en/messages/ardupilotmega.html#COPTER_MODE https://mavlink.io/en/messages/ardupilotmega.html#PLANE_MODE https://mavlink.io/en/messages/ardupilotmega.html#ROVER_MODE

Thanks @tridge .. Have made the changes

@peterbarker peterbarker merged commit 062f82b into ArduPilot:master Sep 1, 2023
84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srmainwaring srmainwaring srmainwaring approved these changes

@Ryanf55 Ryanf55 Ryanf55 approved these changes

@tridge tridge Awaiting requested review from tridge

Assignees
No one assigned
Labels
ROS
Projects
DDS/ROS2
Status: ✅ Done
GSoC-2023 ROS2 Gazebo
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@arshPratap @srmainwaring @tridge @Ryanf55 @peterbarker