AP_DDS: Added verbose debugging output messages #24740
Conversation
libraries/AP_DDS/AP_DDS_Client.cpp
Outdated
| @@ -673,14 +681,16 @@ bool AP_DDS_Client::create() | |||
| requests[2] = dwriter_req_id; | |||
|
|
|||
| if (!uxr_run_session_until_all_status(&session, requestTimeoutMs, requests, status, nRequests)) { | |||
| GCS_SEND_TEXT(MAV_SEVERITY_ERROR,"XRCE Client: Topic/Pub/Writer session request failure for index '%u'",i); | |||
| //probably have errors on a different debug level | |||
There was a problem hiding this comment.
Agree, can you figure out how to do this?
There was a problem hiding this comment.
@Ryanf55 updated the PR..could you take a look ?
Thanks
arshPratap
force-pushed
the
ddsDebugMessage
branch
from
9289774
to
7d269e0
Compare
libraries/AP_DDS/AP_DDS_Client.h
Outdated
| @@ -28,6 +28,8 @@ | |||
| #define DDS_MTU 512 | |||
| #define DDS_STREAM_HISTORY 8 | |||
| #define DDS_BUFFER_SIZE DDS_MTU * DDS_STREAM_HISTORY | |||
| #define debug(fmt, args ...) do { if (debug_level) { GCS_SEND_TEXT(MAV_SEVERITY_INFO, "DDS_DEBUG: " fmt, ## args); } } while (0) | |||
There was a problem hiding this comment.
why not pass a debug level to the debug() macro? so:
debug(3, MAV_SEVERITY_INFO, "DDS: an unimportant debug message");
There was a problem hiding this comment.
Could potentially just use the MAV_SEVERITY_LEVEL.... MAV_SEVERITY_INFO in this case. Do you need the extra parameter?
|
Overall, I'm still confused as to the need for this, and what problem this is solving. If you do a rebase on master, you'll see that the subscribers that are implemented (the only ones that would have high-rate messages to the ground station) have no messages during normal operation. In the case the TF tree is publishing an empty tree, that's a coding error and would result in no localization data. During initialization, which only happens once, the error messages should be shown as errors because there was a mismatch in config. |
arshPratap
force-pushed
the
ddsDebugMessage
branch
from
7d269e0
to
2669e2c
Compare
|
@Ryanf55 I suggested this as the code was printing a message on each packet for things like joystick and mode change etc. That is fine while still under development, but just annoying for end users. If the debug msgs are not needed any more they could be removed, if still needed we can use a Debug() macro and DDS_DEBUG parameter |
|
@Ryanf55 and @tridge, I suggested to @arshPratap that errors should still be displayed to the console, and the messages echoing external input could be replaced with a debug macro. That leaves the case where we still might get flooded with error messages (say a joystick input with too few fields). Is there an established pattern in AP for printing an error message once on first issue (with maybe an option of resetting if the issue is resolved so it displays again if the input degrades later)? |
As discussed in #24145 , with @tridge .. I have converted several output messages to debugging based output messages.
Was planning to have the ERROR messages and the subsequent ERROR status messages be shown in deeper debugging levels.
@Ryanf55 @srmainwaring thoughts ?