Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plane: use dead zone in stick mixing #24873

Merged
merged 1 commit into from Sep 10, 2023

Conversation

tridge
Copy link
Contributor

@tridge tridge commented Sep 4, 2023

prevent small stick offsets causing navigation errors

Copy link
Member

@IamPete1 IamPete1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Will need testing in every mode, I would be un-surprised to find other cases were were not updating them.

We might need to cache old values for MAVLink to report?

@tridge
Copy link
Contributor Author

tridge commented Sep 4, 2023

We might need to cache old values for MAVLink to report?

I think the mavlink output will always happen after the mode up, but if mavlink moved to its own thread we could be in trouble.
I'm more concerned about possible access to these variables in scripting and things like FrSky telem. I haven't traced through any possible issues there yet

@tridge
Copy link
Contributor Author

tridge commented Sep 4, 2023

another potential problem is code which reads nav_roll_cd to determine what to do, see for example Plane::servos_auto_trim(). That case is OK I think as it is called late, but there may be others
@IamPete1 maybe we need a set_nav_roll() and set_nav_pitch() call, which set a boolean to say they have been updated, and if false when we output then zero?

@tridge
Copy link
Contributor Author

tridge commented Sep 5, 2023

check rudder for dz usage

this prevents small RC input deviations from impacting non-pilot
controlled modes via stick mixing
@tridge tridge merged commit 94201f1 into ArduPilot:master Sep 10, 2023
54 checks passed
@rmackay9 rmackay9 added this to Pending in Copter-4.4 Sep 12, 2023
@tridge tridge added this to 4.4.2-beta1 in Plane 4.4 Oct 12, 2023
@rmackay9 rmackay9 moved this from Pending to 4.4.2 / 4.4.2-beta1 in Copter-4.4 Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Copter-4.4
4.4.2 / 4.4.2-beta1
Plane 4.4
4.4.2-beta1
Development

Successfully merging this pull request may close these issues.

None yet

3 participants