Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop trying to stream MAG_CAL messages if mag cal not compiled in #25050

Merged
merged 6 commits into from Sep 26, 2023

Conversation

peterbarker
Copy link
Contributor

This is fatal in SITL, a warning on real vehicles.

…e cal disabled

fatal error in SITL if we try to send messages with these disabled
…l disabled

fatal error in SITL if we try to send messages with these disabled
… disabled

fatal error in SITL if we try to send messages with these disabled
…isabled

fatal error in SITL if we try to send messages with these disabled
…abled

fatal error in SITL if we try to send messages with these disabled
…abled

fatal error in SITL if we try to send messages with these disabled
Copy link
Contributor

@khancyr khancyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree.
Rest is already covered by ifdef, so this removal is legit. (

#if COMPASS_CAL_ENABLED
)

@tridge tridge merged commit b7e4e97 into ArduPilot:master Sep 26, 2023
82 checks passed
@peterbarker peterbarker deleted the pr/compass-message-fix branch September 26, 2023 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants