-
Notifications
You must be signed in to change notification settings - Fork 17k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Network: added TCP client and server and UDP server #25634
Conversation
This is working 100% for me on my Cube Red. I can run multiple instances and have it rock-solid on Mission Planner. No problems at all. However, @tridge is having some weird crashing behavior on his end that he's chasing down when he connects on TCP on both CubeRed and Pixhawk6X. |
0beb909
to
24c086d
Compare
@magicrub I'm now happy with this - changing to use malloc() instead of the lwip memory pools solved the issue for me |
24c086d
to
8b31b0a
Compare
Does this still require removing ekf2 to fit in pixhawk6x? |
ekf2 is now disabled by default thanks to the recent PR from @peterbarker, I think it would fit either way though. I only had to disable ekf2 in order to build with --debug |
4228d38
to
55b81b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tridge and I have been banging on this over the last few days. It's looking very good now and it ready to merge! There's still some odd/wrong behavior when using UDPClient in broadcast mode but everything else seems to work so lets get this beast merged and start another PR to chase the loose-ends
this prevents a race condition with a static string
this simplifies the networking code
and implement mavlink packetisation and flow control return
55b81b4
to
1555dc9
Compare
Also implement mavlink packetisation, and flow control