Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network: added TCP client and server and UDP server #25634

Merged
merged 8 commits into from
Nov 28, 2023

Conversation

tridge
Copy link
Contributor

@tridge tridge commented Nov 26, 2023

Also implement mavlink packetisation, and flow control

@magicrub
Copy link
Contributor

This is working 100% for me on my Cube Red. I can run multiple instances and have it rock-solid on Mission Planner. No problems at all. However, @tridge is having some weird crashing behavior on his end that he's chasing down when he connects on TCP on both CubeRed and Pixhawk6X.

@tridge tridge force-pushed the pr-network-types branch 2 times, most recently from 0beb909 to 24c086d Compare November 27, 2023 05:40
@tridge
Copy link
Contributor Author

tridge commented Nov 27, 2023

@magicrub I'm now happy with this - changing to use malloc() instead of the lwip memory pools solved the issue for me

@magicrub
Copy link
Contributor

Does this still require removing ekf2 to fit in pixhawk6x?

@tridge
Copy link
Contributor Author

tridge commented Nov 27, 2023

Does this still require removing ekf2 to fit in pixhawk6x?

ekf2 is now disabled by default thanks to the recent PR from @peterbarker, I think it would fit either way though. I only had to disable ekf2 in order to build with --debug

@tridge tridge force-pushed the pr-network-types branch 3 times, most recently from 4228d38 to 55b81b4 Compare November 27, 2023 21:38
Copy link
Contributor

@magicrub magicrub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tridge and I have been banging on this over the last few days. It's looking very good now and it ready to merge! There's still some odd/wrong behavior when using UDPClient in broadcast mode but everything else seems to work so lets get this beast merged and start another PR to chase the loose-ends

@Hwurzburg Hwurzburg added the WikiNeeded needs wiki update label Nov 28, 2023
@tridge tridge merged commit 2ee48de into ArduPilot:master Nov 28, 2023
87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Networking WikiNeeded needs wiki update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants