-
Notifications
You must be signed in to change notification settings - Fork 17k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add detected message when GPS found #26257
Conversation
da6fe85
to
6f66be6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, that is less confusing I think
@@ -499,7 +499,7 @@ const AP_Param::GroupInfo SIM::var_gps[] = { | |||
// @Param: GPS_TYPE | |||
// @DisplayName: GPS 1 type | |||
// @Description: Sets the type of simulation used for GPS 1 | |||
// @Values: 0:None, 1:UBlox, 5:NMEA, 6:SBP, 7:File, 8:Nova, 9:SBP, 10:Trimble, 19:MSP | |||
// @Values: 0:None, 1:UBlox, 5:NMEA, 6:SBP, 7:File, 8:Nova, 9:SBP2, 11:Trimble, 19:MSP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't trimble a SBF type ? so we that would be 10 ? @Ryanf55
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, Trimble PX1 uses GSOF as a protocol and has no affiliation with SBF.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok so some comment on ap_gps are misleading then as they said sbf and trimble are similar
6f66be6
to
fd8c449
Compare
libraries/AP_GPS/AP_GPS.cpp
Outdated
|
||
// we set delta_time_ms to the timeout value when clearing | ||
// state; use it being zero to mark first message | ||
if (timing[instance].delta_time_ms == GPS_TIMEOUT_MS) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems odd - what stops delta_time_ms from being GPS_TIMEOUT_MS later in the flight?
maybe a "bool announced_gps" variable would be better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a bool.
fd8c449
to
0bae80c
Compare
Master:
after this PR:
And the most common uBlox case where the thing got auto-configured:
![image](https://private-user-images.githubusercontent.com/7077857/305756001-97155d72-9e56-4c2f-92e2-e5016b48f946.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjM2NjYwNzgsIm5iZiI6MTcyMzY2NTc3OCwicGF0aCI6Ii83MDc3ODU3LzMwNTc1NjAwMS05NzE1NWQ3Mi05ZTU2LTRjMmYtOTJlMi1lNTAxNmI0OGY5NDYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgxNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MTRUMjAwMjU4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MzFlZGU0ZjM4NmM5NTNkMDAyYjNkZmIxZmQyMjlhNzRiODA4YjE5NGU3ZmNmNjVjMTNiNmUxOWI5YzcyMTU4YiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.35IwGVk9FbHkfbMvd8iwlNrqo85kVhg9gqYBNEwRaGA)