Implement RX bind for CRSF #26375
Merged
Implement RX bind for CRSF #26375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbarker
requested changes
Mar 2, 2024
There was a problem hiding this comment.
There should be no caller to this When HAL_CRSF_TELEM_ENABLED is false, so remove it completely.
You could also remove it from the header file if you felt like it; if you do so you cet a compile-time rather than link-time failure which makes it easier to find and fix build problems.
|
Tested and working with TBS RX |
Preferred my solution which was far less hassle and avoid all sorts of compilation problems |
peterbarker
approved these changes
Mar 11, 2024
tridge
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CRSF supports a bind command, this uses it to support mavlink bind for CRSF