Move AP_BoardConfig parameters up to AP_Vehicle #26550
Open
+78
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbarker
force-pushed
the
pr/boardconfig-to-ap_vehicle
branch
from
684ee99
to
0ed5169
Compare
Also create a define to make having the singleton optional, as the library is sometimes used without instantiation via a number of static methods
Also create a define to make having the singleton optional, as the library is sometimes used without instantiation via a number of static methods
Also create a define to make having the singleton optional, as the library is sometimes used without instantiation via a number of static methods
Also create a define to make having the singleton optional, as the library is sometimes used without instantiation via a number of static methods
Also create a define to make having the singleton optional, as the library is sometimes used without instantiation via a number of static methods
Also create a define to make having the singleton optional, as the library is sometimes used without instantiation via a number of static methods
Also create a define to make having the singleton optional, as the library is sometimes used without instantiation via a number of static methods
peterbarker
force-pushed
the
pr/boardconfig-to-ap_vehicle
branch
from
0ed5169
to
0882967
Compare
Also create a define to make having the singleton optional, as the library is sometimes used without instantiation via a number of static methods
Also create a define to make having the singleton optional, as the library is sometimes used without instantiation via a number of static methods
Also create a define to make having the singleton optional, as the library is sometimes used without instantiation via a number of static methods
Also create a define to make having the singleton optional, as the library is sometimes used without instantiation via a number of static methods
Also create a define to make having the singleton optional, as the library is sometimes used without instantiation via a number of static methods
Also create a define to make having the singleton optional, as the library is sometimes used without instantiation via a number of static methods
peterbarker
force-pushed
the
pr/boardconfig-to-ap_vehicle
branch
from
0882967
to
399886c
Compare
|
If were doing some param conversion anyway maybe we should take the opportunity to move the RTS/CTS over to serial manager. |
I think those parameters are going to be rather problematic to convert; (sensibly) they'd have to be real parameters, not bitmask bits, and they don't make sense on all SERIALn parameters sets, only those you have pins for. Definitely would be a good thing to get cleaned up, but also not one to attack on this PR IMO. |
|
@peterbarker we will look at top level params for AP_Vehicle first, if not palatable then we will go ahead with this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add a define to allow it to not be in AP_Vehicle
Tested the parameter upgrade on a CubeOrange (
BRD_RTS_CTS1_ENABLED) , and with the new test script for all vehicles in SITL.