Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove VRBrain board sub-types #26583

Merged
merged 3 commits into from Mar 26, 2024

Conversation

peterbarker
Copy link
Contributor

these were only used for arranging which Notify LED backends to select, so eliminate them in favour of a specific "backend-style" define.

these were only used to turn choose between AP_Notify LED backends, which can be done much more neatly with specific features defines.
these were only used to turn choose between AP_Notify LED backends, which can be done much more neatly with specific features defines.
these were only used to turn choose between AP_Notify LED backends, which can be done much more neatly with specific features defines.
@peterbarker
Copy link
Contributor Author

I've checked for binary output changes after this PR, and these are the changes:

pbarker@threads:~/rc/ardupilot$ ~/rc/ardupilot/Tools/scripts/filter_size_compare_branches_csv.py /tmp/some.csv  --hide-bin 
------------------------  -----  ----------  ------  ----  -----  -----  ---
Board                     blimp  bootloader  copter  heli  plane  rover  sub
SITL_arm_linux_gnueabihf  0                  0       0     0      0      0
SITL_x86_64_linux_gnu     0                  0       0     0      0      0
VRBrain-v51               -8     *           -16     -8    -8     -16    -8
VRBrain-v52               -16    *           -8      -16   -16    -8     -16
VRBrain-v54               -8     *           -8      0     -8     -8     -8
VRCore-v10                -8     *           -16     -8    -8     -16    -8
VRUBrain-v51              -8     *           -16     -8    -8     -16    -8
------------------------  -----  ----------  ------  ----  -----  -----  ---
pbarker@threads:~/rc/ardupilot$ 

... so the only boards affected are the VRBrain boards.

I've looked with elf-diff, and it's only ROMFS which is changed on those boards (hwdef.dat inclusion)

@tridge tridge merged commit 44477c3 into ArduPilot:master Mar 26, 2024
91 checks passed
@peterbarker peterbarker deleted the pr/remove-vrbrain-board-subtypes branch April 1, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants