Tidy HAL_GPIO_LED_ON and _OFF #26642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tridge
approved these changes
Apr 2, 2024
peterbarker
force-pushed
the
pr/HAL_GPIOS_LED_-tidy
branch
from
b7a6187
to
8f5f320
Compare
this same defaulting is being done in AP_HAL_ChibiOS/GPIO.h
the current "flexibility" allows for ON/OFF to be the same value. Many hwdef files where only setting one of these, leaving the other at teh default, too....
... or the _OFF entry, which is simply !HAL_GPIO_MED_ON
this value is the default value anyway, so don't make many copies..
these can be reused across different vehicles
these can be reused across different vehicles
peterbarker
force-pushed
the
pr/HAL_GPIOS_LED_-tidy
branch
from
8f5f320
to
f9fdfdb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have run this through
size_compare_branches.pyand there are no compiler output changes.