Copter: guided mode fix for landing detector internal error #26866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
70 tasks
rmackay9
force-pushed
the
copter-guided-att-interr-fix
branch
from
7ba2079
to
9671055
Compare
|
Enable the disabled autotest for this problem? |
|
Thanks for that. I've enabled it now and it passes! |
IamPete1
approved these changes
Apr 22, 2024
rmackay9
force-pushed
the
copter-guided-att-interr-fix
branch
from
d78aeeb
to
e74a8eb
Compare
|
Rebased on master in the hopes that it passes the #$% Dynamic notch flapping test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves an Internal Error (see issue #26865) which is caused by Guided mode neglecting its responsibility to call set_land_complete(false) when it believes the vehicle has taken off.
This only occurs when the caller is providing SET_ATTITUDE_CONTROL messages where the "thrust" field is really interpreted as a thrust (as opposed to being interpreted as a climb rate).
This has been tested in SITL to confirm that before this fix the issue occurs and afterwards it does not.
The GuideMostThrust autotest (see PR #26782) has also been enabled