AP_HAL_SITL: allow disabling CAN interfaces #27539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
"We"? Did you consider just making 0 "None", shifting everything along one and making the default 1? It's much more in keeping with what we normally do and the number of users of this could be counted on one hand of a clumsy carpenter. |
|
“We” is a grammar quirk I have, the idea was wholly my own :) I did consider renumbering but was concerned it would change CAN behavior in people’s existing SITL instances. If updating the default is sufficient to avoid that, and/or the change is not a big problem, then yes I think renumbering is a lot better. |
Also corrects an issue where setting an invalid type could result in undefined behavior.
Also corrects an issue where setting an invalid type could result in undefined behavior.
tpwrules
force-pushed
the
pr/sitl-disable-can
branch
from
b77cec2
to
a92c213
Compare
|
I checked and updating the default is indeed sufficient, so I went with 0=None. |
tridge
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also corrects an issue where setting an invalid type could result in undefined behavior.
Tested by running two peripherals on two different buses.