DroneCAN: update DSDL compiler #27606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the following issues: * Compound array elements subject to tail array optimization could be decoded incorrectly, causing a decode failure. * Invalid array lengths could be sent over the wire if a longer-than-max array was encoded (though only the max number of elements was sent). * Lengths were not validated when decoding arrays of compound elements using TAO, causing memory corruption if an invalid length was received. * Union tags were not validated, causing undefined behavior if an invalid tag was received.
tridge
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following issues:
Compound array elements subject to tail array optimization could be decoded incorrectly, causing a decode failure.
Invalid array lengths could be sent over the wire if a longer-than-max array was encoded (though only the max number of elements was sent).
Lengths were not validated when decoding arrays of compound elements using TAO, causing memory corruption if an invalid length was received.
Union tags were not validated, causing undefined behavior if an invalid tag was received.
Tested in SITL using quadplane-can. Also tested on the bench using Cube Orange, including testing that a flight controller with this update can talk to a periph without it.