Use common GCS functions from superclass #6553
Conversation
peterbarker
force-pushed
the
gcs-remove-funcs
branch
2 times, most recently
from
e77c0a7
to
1e734b4
Compare
libraries/GCS_MAVLink/GCS_Common.cpp
Outdated
| /* fall through */ | ||
| case MAVLINK_MSG_ID_MISSION_SET_CURRENT: | ||
| /* fall through */ | ||
| case MAV_CMD_MISSION_START: |
There was a problem hiding this comment.
This seems wrong. Message ID will never be a command ID.
There was a problem hiding this comment.
That's... odd. Fixed.
libraries/GCS_MAVLink/GCS_Common.cpp
Outdated
| break; | ||
| } | ||
|
|
||
| case MAVLINK_MSG_ID_MISSION_ITEM_INT: |
There was a problem hiding this comment.
Any reason the code below is duplicated from above?
There was a problem hiding this comment.
That's the way it came in from the donor library. I did see it, but decided I was moving code, not fixing it :-)
I'll add a patch on top to remove the duplication.
There was a problem hiding this comment.
That's funny because I noticed this because I saw one of the vehicles not having the duplicated code 🙂
peterbarker
force-pushed
the
gcs-remove-funcs
branch
from
b99c15a
to
9d97221
Compare
|
@OXINARF I've moved the MISSION_ACK stuff up now. |
|
@peterbarker Do you mind if I squash the last 4 commits? @magicrub Again, why dev call topic? This is basically a non-functional change... |
|
@OXINARF Not at all - squash away! |
|
As agreed, squashed and merged, thanks! |
No description provided.