AP_Baro: New AP_Baro_Keller device driver #6787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
great stuff. |
OXINARF
reviewed
Aug 21, 2017
| _sem->give(); | ||
|
|
||
| uint16_t raw_pressure_avg = ((float)sum_pressure) / num_samples; | ||
| uint16_t raw_temperature_avg = ((float)sum_temperature) / num_samples; |
There was a problem hiding this comment.
Why the float cast? Those are floats already
There was a problem hiding this comment.
whoops, dev remnants. Thanks.
tridge
approved these changes
Aug 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a line of pressure transducers that can measure up to 200 bar (2000 meters water depth). The current MS5837 device is rated to only 30 bar. Let's go deeper with ArduSub!