COPTER: Don't log battery failsafe error when failsafe disabled #7639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves setting ERROR_SUBSYSTEM_FAILSAFE_BATT logging call up to the if block so it is only set if the battery failsafe is enabled. The low battery GCS message and AP_Notify stuff still goes through as it should. Also renamed the function from set_failsafe_battery to set_low_battery since it actually is only handlng the low battery notification, not the failsafe notification.
|
#7213 creates the same result as well (among other things). |
|
I would deffer to yours and close this if yours is going to proceed. |
|
@Pedals2Paddles It is the intention that @WickedShell's goes forward, so I'm closing this. Smack me if I'm taking too long to review the other one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves setting the
ERROR_SUBSYSTEM_FAILSAFE_BATTlogging call up to the if block so the failsafe error it is only set if the battery failsafe is enabled. Previously, you would get the error logging and GCS warning for failsafe even if the failsafe was disabled.The low battery GCS message and AP_Notify stuff still goes through as normal, since those are only notifying of the low battery condition, not the failsafe itself. Also renamed the function from
set_failsafe_batterytoset_low_batterysince it actually is only handling the low battery notification, not the failsafe notification.This should close #7619