Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HAL_F4Light: removed SPL submodule #8603

Merged
merged 2 commits into from
Jun 14, 2018

Conversation

tridge
Copy link
Contributor

@tridge tridge commented Jun 8, 2018

this submodule contains files licensed under the ST liberty_v2 license,
which is not compatible with the GPL

Unfortunately removing this breaks the F4Light build. People wanting to
build F4Light will need modifications locally

@auturgy
Copy link
Contributor

auturgy commented Jun 8, 2018

I completely agree with the rationale behind this. It will need a dapo post to explain though, I think.

@tridge
Copy link
Contributor Author

tridge commented Jun 11, 2018

unfortunately even after we apply this PR we will still have quite a few files licensed under the ST liberty_v2 license. For example:
https://github.com/ArduPilot/ardupilot/blob/master/libraries/AP_HAL_F4Light/hardware/STM32_USB_Driver/usb_core.c#L17
I think we will have to go further and remove F4Light HAL. If the HAL got cleaned up to remove all ST code that is under this license then it could come back in.

@tridge
Copy link
Contributor Author

tridge commented Jun 14, 2018

This PR has now been expanded to remove the two submodules and the ST code for USB. It doesn't remove the rest of F4Light.
I'm currently thinking we can leave the rest in to make it easier for @night-ghost to maintain F4Light out of our tree if he wants to.
That also will make it easier to re-enable F4Light if either ST changes their license or @night-ghost rewrites code to not use the ST licensed code.
Also note that we have written to ST to ask them about the license.

@tridge tridge merged commit 5d20699 into ArduPilot:master Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants