Make testing equivalence of floats in SITL a compilation error #9196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbarker
force-pushed
the
sitl-float-equal
branch
from
3978a7a
to
f1a4863
Compare
|
The last patch here has me a little dubious; should we really be using an epsilon? Perhaps we should instead pragma-off the compiler error for test_math.cpp? |
magicrub
approved these changes
Aug 15, 2018
tridge
previously requested changes
Aug 16, 2018
libraries/SITL/SIM_XPlane.cpp
Outdated
| @@ -241,7 +241,7 @@ bool XPlane::receive_data(void) | |||
| */ | |||
| bool has_magic = ((uint32_t)(data[1] * throttle_magic_scale) % 1000U) == (uint32_t)(throttle_magic * throttle_magic_scale); | |||
| if (data[1] < 0 || | |||
| data[1] == throttle_sent || | |||
| is_equal(data[1], throttle_sent) || | |||
There was a problem hiding this comment.
no, this really, really needs to be ==, a epsilon will break this
peterbarker
force-pushed
the
sitl-float-equal
branch
from
f1a4863
to
e9bbcc5
Compare
peterbarker
dismissed
tridge’s stale review
pramga'd the -Werror away instead.
peterbarker
force-pushed
the
sitl-float-equal
branch
from
e9bbcc5
to
f87b828
Compare
|
Assigned devcalltopic in case somebody on the call knows the tests should be strict-equivalence. |
There are legitimate reasons for doing direct equivalence in these files
peterbarker
force-pushed
the
sitl-float-equal
branch
from
f87b828
to
2989c01
Compare
|
It was decided on the devcall that the math tests should be allowed to directly compare floats for equivalence, on the basis that they should know what they're doing. Removed old changes, pragma'd away the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.