ardupilot: added MCU_STATUS message #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbarker
reviewed
Aug 23, 2021
Comment on lines
1742
to
1745
| <field type="uint16_t" name="MCU_temperature" units="cdegC">MCU Internal temperature</field> | ||
| <field type="uint16_t" name="MCU_voltage" units="mV">MCU voltage</field> | ||
| <field type="uint16_t" name="MCU_voltage_min" units="mV">MCU voltage minimum</field> | ||
| <field type="uint16_t" name="MCU_voltage_max" units="mV">MCU voltage maximum</field> |
There was a problem hiding this comment.
MCU_ and MCU seem a touch redundant here.
There was a problem hiding this comment.
no, we could also monitor the supply voltage in the future, the description does need to be specific. The MCU is capable of monitoring different voltage types
| <field type="uint8_t" name="id" instance="true">MCU instance</field> | ||
| <field type="uint16_t" name="MCU_temperature" units="cdegC">MCU Internal temperature</field> | ||
| <field type="uint16_t" name="MCU_voltage" units="mV">MCU voltage</field> | ||
| <field type="uint16_t" name="MCU_voltage_min" units="mV">MCU voltage minimum</field> |
There was a problem hiding this comment.
Suggested change
| <field type="uint16_t" name="MCU_voltage_min" units="mV">MCU voltage minimum</field> | |
| <field type="uint16_t" name="MCU_voltage_min" units="mV">Minimum voltage measured</field> |
|
need to change temperature to signed |
peterbarker
reviewed
Aug 23, 2021
used for H7 MCU monitoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
used for H7 MCU monitoring. MCU temperature is useful for overheating, and the voltage range gives us an idea of how stable the power supply is