New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: store development docker files in docker/development #2053

Merged
merged 1 commit into from Feb 2, 2019

Conversation

Projects
None yet
4 participants
@faustbrian
Copy link
Collaborator

faustbrian commented Feb 2, 2019

Proposed changes

Moves the development docker files so @adrian69 can store the production files in a sub-directory.

Types of changes

  • Build (changes that affect the build system)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Feb 2, 2019

@supaiku0 @air1one - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 2, 2019

Codecov Report

Merging #2053 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #2053   +/-   ##
=======================================
  Coverage     73.8%   73.8%           
=======================================
  Files          367     367           
  Lines         8258    8258           
  Branches      1209    1177   -32     
=======================================
  Hits          6095    6095           
- Misses        2129    2131    +2     
+ Partials        34      32    -2
Impacted Files Coverage Δ
packages/core-test-utils/src/helpers/container.ts 0% <0%> (ø) ⬆️
packages/core-test-utils/src/generators/wallets.ts 14.28% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2c99e6...743e30b. Read the comment docs.

1 similar comment
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 2, 2019

Codecov Report

Merging #2053 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #2053   +/-   ##
=======================================
  Coverage     73.8%   73.8%           
=======================================
  Files          367     367           
  Lines         8258    8258           
  Branches      1209    1177   -32     
=======================================
  Hits          6095    6095           
- Misses        2129    2131    +2     
+ Partials        34      32    -2
Impacted Files Coverage Δ
packages/core-test-utils/src/helpers/container.ts 0% <0%> (ø) ⬆️
packages/core-test-utils/src/generators/wallets.ts 14.28% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2c99e6...743e30b. Read the comment docs.

@supaiku0 supaiku0 merged commit 27e4aa6 into develop Feb 2, 2019

6 checks passed

ci/circleci: test-node10-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-2 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-2 Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the refactor/docker branch Feb 2, 2019

vasild added a commit that referenced this pull request Feb 4, 2019

Merge remote-tracking branch 'ArkEcosystem/core/develop' into verify-…
…peer-state

* ArkEcosystem/core/develop:
  chore: few upgrade script fixes (#2060)
  misc: add github templates for docs, security and support (#2059)
  fix: remove entries with double and single quotes during the upgrade
  fix: syntax error in upgrade script
  fix(crypto): disable multisig (#2057)
  chore: add bash fallback for ARK > CORE in upgrade script
  refactor: move genesisBlock to network config and remove extraneous config (#2052)
  chore: store development docker files in docker/development (#2053)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment