Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: 2.5.0 #2795

Merged
merged 80 commits into from Jul 11, 2019

Conversation

Projects
None yet
7 participants
@faustbrian
Copy link
Collaborator

commented Jul 10, 2019

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

faustbrian and others added some commits Jun 13, 2019

supaiku0 and others added some commits Jul 9, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Jul 10, 2019

Codecov Report

Merging #2795 into master will decrease coverage by 0.45%.
The diff coverage is 72.2%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2795      +/-   ##
==========================================
- Coverage   65.77%   65.31%   -0.46%     
==========================================
  Files         402      363      -39     
  Lines        8858     8189     -669     
  Branches      454      391      -63     
==========================================
- Hits         5826     5349     -477     
+ Misses       2982     2806     -176     
+ Partials       50       34      -16
Impacted Files Coverage Δ
...core-api/src/handlers/shared/transformers/ports.ts 70% <ø> (ø)
packages/core-api/src/handlers/votes/routes.ts 100% <ø> (ø)
packages/core-api/src/handlers/wallets/routes.ts 100% <ø> (ø)
...kages/core-api/src/handlers/transactions/routes.ts 100% <ø> (ø)
packages/core-api/src/handlers/delegates/routes.ts 100% <ø> (ø)
...ackages/core-api/src/handlers/peers/transformer.ts 75% <ø> (ø)
packages/core-api/src/handlers/rounds/routes.ts 100% <ø> (ø)
packages/core-snapshots/src/manager.ts 0% <ø> (ø) ⬆️
packages/core-p2p/src/schemas.ts 75% <ø> (ø) ⬆️
...ckages/core-api/src/handlers/rounds/transformer.ts 100% <ø> (ø)
... and 106 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cead487...c385d7a. Read the comment docs.

@codecov-io

This comment has been minimized.

Copy link

commented Jul 10, 2019

Codecov Report

Merging #2795 into master will decrease coverage by 0.43%.
The diff coverage is 72.1%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2795      +/-   ##
==========================================
- Coverage   65.77%   65.33%   -0.44%     
==========================================
  Files         402      363      -39     
  Lines        8858     8192     -666     
  Branches      454      427      -27     
==========================================
- Hits         5826     5352     -474     
+ Misses       2982     2802     -180     
+ Partials       50       38      -12
Impacted Files Coverage Δ
...core-api/src/handlers/shared/transformers/ports.ts 70% <ø> (ø)
packages/core-api/src/handlers/votes/routes.ts 100% <ø> (ø)
packages/core-api/src/handlers/wallets/routes.ts 100% <ø> (ø)
...kages/core-api/src/handlers/transactions/routes.ts 100% <ø> (ø)
packages/core-api/src/handlers/delegates/routes.ts 100% <ø> (ø)
...ackages/core-api/src/handlers/peers/transformer.ts 75% <ø> (ø)
packages/core-api/src/handlers/rounds/routes.ts 100% <ø> (ø)
packages/core-p2p/src/schemas.ts 75% <ø> (ø) ⬆️
...ckages/core-api/src/handlers/rounds/transformer.ts 100% <ø> (ø)
...kages/core-api/src/handlers/wallets/transformer.ts 100% <ø> (ø)
... and 105 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cead487...f48b2d8. Read the comment docs.

@codecov-io

This comment has been minimized.

Copy link

commented Jul 10, 2019

Codecov Report

Merging #2795 into master will decrease coverage by 0.45%.
The diff coverage is 72.2%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2795      +/-   ##
==========================================
- Coverage   65.77%   65.31%   -0.46%     
==========================================
  Files         402      363      -39     
  Lines        8858     8189     -669     
  Branches      454      391      -63     
==========================================
- Hits         5826     5349     -477     
+ Misses       2982     2806     -176     
+ Partials       50       34      -16
Impacted Files Coverage Δ
...core-api/src/handlers/shared/transformers/ports.ts 70% <ø> (ø)
packages/core-api/src/handlers/votes/routes.ts 100% <ø> (ø)
packages/core-api/src/handlers/wallets/routes.ts 100% <ø> (ø)
...kages/core-api/src/handlers/transactions/routes.ts 100% <ø> (ø)
packages/core-api/src/handlers/delegates/routes.ts 100% <ø> (ø)
...ackages/core-api/src/handlers/peers/transformer.ts 75% <ø> (ø)
packages/core-api/src/handlers/rounds/routes.ts 100% <ø> (ø)
packages/core-snapshots/src/manager.ts 0% <ø> (ø) ⬆️
packages/core-p2p/src/schemas.ts 75% <ø> (ø) ⬆️
...ckages/core-api/src/handlers/rounds/transformer.ts 100% <ø> (ø)
... and 106 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cead487...c385d7a. Read the comment docs.

faustbrian and others added some commits Jul 10, 2019

@faustbrian faustbrian marked this pull request as ready for review Jul 11, 2019

@faustbrian faustbrian merged commit 3675ebb into master Jul 11, 2019

15 checks passed

ci/circleci: node10-benchmark Your tests passed on CircleCI!
Details
ci/circleci: node10-e2e Your tests passed on CircleCI!
Details
ci/circleci: node10-functional Your tests passed on CircleCI!
Details
ci/circleci: node10-integration Your tests passed on CircleCI!
Details
ci/circleci: node10-unit Your tests passed on CircleCI!
Details
ci/circleci: node11-benchmark Your tests passed on CircleCI!
Details
ci/circleci: node11-e2e Your tests passed on CircleCI!
Details
ci/circleci: node11-functional Your tests passed on CircleCI!
Details
ci/circleci: node11-integration Your tests passed on CircleCI!
Details
ci/circleci: node11-unit Your tests passed on CircleCI!
Details
ci/circleci: node12-benchmark Your tests passed on CircleCI!
Details
ci/circleci: node12-e2e Your tests passed on CircleCI!
Details
ci/circleci: node12-functional Your tests passed on CircleCI!
Details
ci/circleci: node12-integration Your tests passed on CircleCI!
Details
ci/circleci: node12-unit Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.