release: 2.5.0 #2795

faustbrian · 2019-07-10T14:20:19Z

What kind of change does this PR introduce?

Does this PR introduce a breaking change?

Yes
No

Does this PR release a new version?

Yes
No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

It's submitted to the develop branch, not the master branch
All tests are passing
New/updated tests are included

If adding a new feature, the PR's description includes:

A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

…2697)

…g and deleting blocks (#2707)

…id (#2671)

…2714)

…2717)

)

…tion is done (#2727)

…2718)

)

…ult mapping to localhost (#2741)

…2787)

…nt-type (#2786)

…2789)

codecov-io · 2019-07-10T14:43:16Z

Codecov Report

Merging #2795 into master will decrease coverage by 0.45%.
The diff coverage is 72.2%.

@@            Coverage Diff             @@
##           master    #2795      +/-   ##
==========================================
- Coverage   65.77%   65.31%   -0.46%     
==========================================
  Files         402      363      -39     
  Lines        8858     8189     -669     
  Branches      454      391      -63     
==========================================
- Hits         5826     5349     -477     
+ Misses       2982     2806     -176     
+ Partials       50       34      -16

Impacted Files	Coverage Δ
...core-api/src/handlers/shared/transformers/ports.ts	`70% <ø> (ø)`
packages/core-api/src/handlers/votes/routes.ts	`100% <ø> (ø)`
packages/core-api/src/handlers/wallets/routes.ts	`100% <ø> (ø)`
...kages/core-api/src/handlers/transactions/routes.ts	`100% <ø> (ø)`
packages/core-api/src/handlers/delegates/routes.ts	`100% <ø> (ø)`
...ackages/core-api/src/handlers/peers/transformer.ts	`75% <ø> (ø)`
packages/core-api/src/handlers/rounds/routes.ts	`100% <ø> (ø)`
packages/core-snapshots/src/manager.ts	`0% <ø> (ø)`	⬆️
packages/core-p2p/src/schemas.ts	`75% <ø> (ø)`	⬆️
...ckages/core-api/src/handlers/rounds/transformer.ts	`100% <ø> (ø)`
... and 106 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cead487...c385d7a. Read the comment docs.

codecov-io · 2019-07-10T14:43:17Z

Codecov Report

Merging #2795 into master will decrease coverage by 0.43%.
The diff coverage is 72.1%.

@@            Coverage Diff             @@
##           master    #2795      +/-   ##
==========================================
- Coverage   65.77%   65.33%   -0.44%     
==========================================
  Files         402      363      -39     
  Lines        8858     8192     -666     
  Branches      454      427      -27     
==========================================
- Hits         5826     5352     -474     
+ Misses       2982     2802     -180     
+ Partials       50       38      -12

Impacted Files	Coverage Δ
...core-api/src/handlers/shared/transformers/ports.ts	`70% <ø> (ø)`
packages/core-api/src/handlers/votes/routes.ts	`100% <ø> (ø)`
packages/core-api/src/handlers/wallets/routes.ts	`100% <ø> (ø)`
...kages/core-api/src/handlers/transactions/routes.ts	`100% <ø> (ø)`
packages/core-api/src/handlers/delegates/routes.ts	`100% <ø> (ø)`
...ackages/core-api/src/handlers/peers/transformer.ts	`75% <ø> (ø)`
packages/core-api/src/handlers/rounds/routes.ts	`100% <ø> (ø)`
packages/core-p2p/src/schemas.ts	`75% <ø> (ø)`	⬆️
...ckages/core-api/src/handlers/rounds/transformer.ts	`100% <ø> (ø)`
...kages/core-api/src/handlers/wallets/transformer.ts	`100% <ø> (ø)`
... and 105 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cead487...f48b2d8. Read the comment docs.

codecov-io · 2019-07-10T14:43:17Z

Codecov Report

Merging #2795 into master will decrease coverage by 0.45%.
The diff coverage is 72.2%.

@@            Coverage Diff             @@
##           master    #2795      +/-   ##
==========================================
- Coverage   65.77%   65.31%   -0.46%     
==========================================
  Files         402      363      -39     
  Lines        8858     8189     -669     
  Branches      454      391      -63     
==========================================
- Hits         5826     5349     -477     
+ Misses       2982     2806     -176     
+ Partials       50       34      -16

Impacted Files	Coverage Δ
...core-api/src/handlers/shared/transformers/ports.ts	`70% <ø> (ø)`
packages/core-api/src/handlers/votes/routes.ts	`100% <ø> (ø)`
packages/core-api/src/handlers/wallets/routes.ts	`100% <ø> (ø)`
...kages/core-api/src/handlers/transactions/routes.ts	`100% <ø> (ø)`
packages/core-api/src/handlers/delegates/routes.ts	`100% <ø> (ø)`
...ackages/core-api/src/handlers/peers/transformer.ts	`75% <ø> (ø)`
packages/core-api/src/handlers/rounds/routes.ts	`100% <ø> (ø)`
packages/core-snapshots/src/manager.ts	`0% <ø> (ø)`	⬆️
packages/core-p2p/src/schemas.ts	`75% <ø> (ø)`	⬆️
...ckages/core-api/src/handlers/rounds/transformer.ts	`100% <ø> (ø)`
... and 106 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cead487...c385d7a. Read the comment docs.

faustbrian and others added 30 commits June 13, 2019 12:51

refactor(core-api): remove the legacy API and support asset search (#…

0ff5241

…2697)

Merge branch 'master' into develop

025dfce

release: 2.5.0-next.0 (#2702)

c96cf3f

release: 2.5.0-next.1 (#2704)

d5c719c

fix(core-p2p): add 2.5 to minimum versions (#2703)

5fa4049

docs(changelog): fix formatting

8b8c433

fix(core-database-postgres): possible database corruption when writin…

a0ba29b

…g and deleting blocks (#2707)

chore(core-database-postgres): add foreign key on transactions block …

0e55dff

…id (#2671)

release: 2.5.0-next.2 (#2713)

ad0e44a

fix(core-api): use CORE_API_DISABLED variable in defaults (#2711)

90187e4

refactor(core-p2p): only look for new peers when below minimum peers (#…

8c3c38a

…2714)

feat(core-webhooks): add option to configure request timeout (#2710)

a6373f3

release: 2.5.0-next.3

d9f4218

feat(core-wallet-api): impose the same rate limit as the public API (#…

2ec6df4

…2717)

refactor(core-wallet-api): always keep the Wallet API enabled (#2715)

24fa281

fix(core-p2p): forget peer when socket is disconnected (#2720)

b0bcb12

perf(core-p2p): improve peer block header check (#2719)

a819326

refactor(core-p2p): only fetch block headers when verifying peers (#2728

3f088a6

)

refactor(core-p2p): delay peer discovery until after state initializa…

142dc3d

…tion is done (#2727)

refactor(core-http-utils): remove createSecureServer method (#2730)

582b8c3

refactor(core-p2p): improved rate limiting (#2729)

4176f3a

fix(core-p2p): off-by-one error when fetching blocks from peer (#2733)

92c0a3d

fix(core): check for user confirmation in snapshot commands (#2734)

49e25f8

test(core-api): transformer service and 404 assertions (#2735)

8d45678

refactor(core-wallet-api): respect the whitelist of the public API (#…

e1de9d1

…2718)

test(core-api): test /transactions/fees and /blockchain endpoints (#2736

2db650b

)

test(core-api): /node/configuration/crypto endpoint (#2737)

f34edcf

test(core-api): /node/fees endpoint (#2738)

fd2d056

chore(docker): Add Wallets API, remove PostgreSQL container port defa…

9c7520e

…ult mapping to localhost (#2741)

docs(docker): Updated README (#2742)

b29f364

spkjp and others added 12 commits July 6, 2019 06:28

fix(crypto): raise bignumber maximum (#2777)

9bccd10

refactor(core): run GC earlier on potatos (#2785)

59aed5d

fix(crypto): allow future timestamps up to 3600 + blocktime seconds (#…

1c01a08

…2787)

refactor(core-http-utils): always enforce application/json as conte…

c642f89

…nt-type (#2786)

refactor(core-forger): increase timeout, check time left in slot (#2788)

4267236

refactor(core-p2p): refresh peer ports (#2784)

c384625

feat(install): let the user choose if they want to use @next release (#…

34c1b56

…2789)

Merge branch 'master' into develop

566ec29

docs(changelog): 2.5.0 (#2790)

dddeaf1

revert: let the user choose if they want to use @next release (#2793)

766870e

fix(core-forger): also check if still in same slot (#2792)

ec68d39

release: 2.5.0-next.8 (#2794)

c385d7a

ghost added Complexity: Undetermined labels Jul 10, 2019

faustbrian and others added 5 commits July 10, 2019 18:34

release: 2.5.0-next.9 (#2796)

009e815

fix(core-api): handle null url and malformed JSON payloads (#2797)

9ea7fed

release: 2.5.0 (#2798)

f48b2d8

docs(changelog): remove reverted PR from 2.5.0

c17a83f

chore(deps): bump @arkecosystem/exchange-json-rpc to 1.0.1 (#2799)

a160194

faustbrian marked this pull request as ready for review July 11, 2019 14:35

faustbrian requested review from air1one, kristjank and spkjp as code owners July 11, 2019 14:35

spkjp approved these changes Jul 11, 2019

View reviewed changes

faustbrian merged commit 3675ebb into master Jul 11, 2019

ghost removed the Status: In Progress label Jul 11, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

release: 2.5.0 #2795

release: 2.5.0 #2795

faustbrian commented Jul 10, 2019 •

edited

Loading

codecov-io commented Jul 10, 2019

codecov-io commented Jul 10, 2019 •

edited

Loading

codecov-io commented Jul 10, 2019

release: 2.5.0 #2795

release: 2.5.0 #2795

Conversation

faustbrian commented Jul 10, 2019 • edited Loading

What kind of change does this PR introduce?

Does this PR introduce a breaking change?

Does this PR release a new version?

codecov-io commented Jul 10, 2019

Codecov Report

codecov-io commented Jul 10, 2019 • edited Loading

Codecov Report

codecov-io commented Jul 10, 2019

Codecov Report

faustbrian commented Jul 10, 2019 •

edited

Loading

codecov-io commented Jul 10, 2019 •

edited

Loading