Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): prevent snapshot commands from running if core is running #3196

Merged
merged 2 commits into from
Nov 4, 2019

Conversation

faustbrian
Copy link
Contributor

Summary

Abort the execution of snapshots command if any core process is active to avoid unexpected side-effects.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link

codecov bot commented Nov 3, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@f284b4b). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #3196   +/-   ##
==========================================
  Coverage           ?   65.62%           
==========================================
  Files              ?      427           
  Lines              ?    12002           
  Branches           ?     1606           
==========================================
  Hits               ?     7876           
  Misses             ?     4093           
  Partials           ?       33
Impacted Files Coverage Δ
packages/core/src/commands/snapshot/dump.ts 0% <0%> (ø)
packages/core/src/commands/snapshot/restore.ts 0% <0%> (ø)
packages/core/src/commands/snapshot/verify.ts 0% <0%> (ø)
packages/core/src/commands/snapshot/truncate.ts 0% <0%> (ø)
packages/core/src/commands/snapshot/rollback.ts 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f284b4b...192fb0e. Read the comment docs.

@spkjp spkjp merged commit 1b3c5b6 into develop Nov 4, 2019
@ghost ghost deleted the snapshot-exit branch November 4, 2019 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants