Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): prevent snapshot commands from running if core is running #3196

Merged
merged 2 commits into from Nov 4, 2019

Conversation

@faustbrian
Copy link
Collaborator

faustbrian commented Nov 3, 2019

Summary

Abort the execution of snapshots command if any core process is active to avoid unexpected side-effects.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 3, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (develop@f284b4b). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #3196   +/-   ##
==========================================
  Coverage           ?   65.62%           
==========================================
  Files              ?      427           
  Lines              ?    12002           
  Branches           ?     1606           
==========================================
  Hits               ?     7876           
  Misses             ?     4093           
  Partials           ?       33
Impacted Files Coverage Δ
packages/core/src/commands/snapshot/dump.ts 0% <0%> (ø)
packages/core/src/commands/snapshot/restore.ts 0% <0%> (ø)
packages/core/src/commands/snapshot/verify.ts 0% <0%> (ø)
packages/core/src/commands/snapshot/truncate.ts 0% <0%> (ø)
packages/core/src/commands/snapshot/rollback.ts 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f284b4b...192fb0e. Read the comment docs.

@supaiku0 supaiku0 merged commit 1b3c5b6 into develop Nov 4, 2019
41 of 54 checks passed
41 of 54 checks passed
bridgechain-registration (12.x) bridgechain-registration (12.x)
Details
crypto (12.x)
Details
unit (12.x)
Details
bridgechain-resignation (12.x) bridgechain-resignation (12.x)
Details
integration (12.x) integration (12.x)
Details
bridgechain-update (12.x) bridgechain-update (12.x)
Details
e2e (12.x)
Details
business-resignation (12.x) business-resignation (12.x)
Details
business-update (12.x) business-update (12.x)
Details
delegate-registration (12.x) delegate-registration (12.x)
Details
delegate-resignation (12.x) delegate-resignation (12.x)
Details
htlc-claim (12.x) htlc-claim (12.x)
Details
htlc-lock (12.x) htlc-lock (12.x)
Details
ipfs (12.x) ipfs (12.x)
Details
vote (12.x) vote (12.x)
Details
codeclimate Code Climate is analyzing this code.
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
security/snyk - __tests__/e2e/package.json (ArkEcosystem) No manifest changes detected
security/snyk - package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-api/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-blockchain/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-container/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-database-postgres/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-database/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-elasticsearch/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-error-tracker-airbrake/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-error-tracker-bugsnag/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-error-tracker-raygun/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-error-tracker-rollbar/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-error-tracker-sentry/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-event-emitter/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-exchange-json-rpc/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-explorer/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-forger/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-http-utils/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-interfaces/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-jest-matchers/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-logger-pino/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-logger-signale/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-logger-winston/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-logger/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-new-relic/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-p2p/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-snapshots/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-state/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-tester-cli/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-transaction-pool/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-transactions/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-utils/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-vote-report/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-wallet-api/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-webhooks/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/crypto/package.json (ArkEcosystem) No manifest changes detected
@ArkEcosystemBot ArkEcosystemBot deleted the snapshot-exit branch Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.