fix(core-database): straight delete blocks during rollback #3773
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Blockchain.removeTopBlocks
now callsBlockRepository.deleteTopBlocks
instead of loading them first throughDatabaseService.getTopBlocks
and then deleting throughBlockRepository.deleteBlocks
.Note that previously
Blockchain.removeTopBlocks
was eating error, only logging it instead of re-throwing.There are two use-cases when blocks have to be deleted:
Improved by this PR.
I plan to refactor revertion to use new
BlockRepository.delgetTopBlock
that pops single block from database renderingBlockRepository.deleteBlocks
obsolete.Checklist