Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-state): log milestone change #3797

Merged
merged 1 commit into from
Jun 13, 2020

Conversation

rainydio
Copy link
Contributor

@rainydio rainydio commented Jun 12, 2020

Summary

Simply log milestone change.

Checklist

  • Ready to be merged

@codecov
Copy link

codecov bot commented Jun 12, 2020

Codecov Report

Merging #3797 into develop will decrease coverage by 5.76%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3797      +/-   ##
===========================================
- Coverage    96.86%   91.10%   -5.77%     
===========================================
  Files          616      616              
  Lines        13861    13863       +2     
  Branches      1672     1672              
===========================================
- Hits         13427    12630     -797     
- Misses         145      947     +802     
+ Partials       289      286       -3     
Flag Coverage Δ
#functional 6.21% <0.00%> (-0.02%) ⬇️
#integration 10.02% <0.00%> (-0.01%) ⬇️
#unit 89.41% <50.00%> (-5.77%) ⬇️
Impacted Files Coverage Δ
packages/core-state/src/stores/state.ts 22.34% <50.00%> (-77.66%) ⬇️
packages/core-state/src/dpos/dpos.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core-state/src/block-state.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core-state/src/state-builder.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core-state/src/stores/blocks.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core-state/src/service-provider.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core-state/src/stores/transactions.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core-state/src/transaction-validator.ts 0.00% <0.00%> (-100.00%) ⬇️
...ackages/core-state/src/dpos/dpos-previous-round.ts 0.00% <0.00%> (-100.00%) ⬇️
...s/core-state/src/actions/build-delegate-ranking.ts 0.00% <0.00%> (-100.00%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b68d5f...45d1d87. Read the comment docs.

@faustbrian faustbrian merged commit cecf892 into develop Jun 13, 2020
@ghost ghost deleted the refactor/core-state/log-milestone-change branch June 13, 2020 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants