fix(core-database): fix delete blocks #3814
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It appears that
BlockRepository.deleteBlocks
was called with array in reverse order (higher height first). This should have raised Removing blocks from the middle error, but didn't. I added more checks, tests, and reversed block order (similarly to how transactions are re-added to pool).This is an attempt to shield
BlockRepository.deleteBlocks
so it can't be called with incorrect arguments that will not throw some error.Checklist