Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-database): initializeActiveDelegates just use current round #3827

Merged
merged 5 commits into from
Jun 25, 2020

Conversation

air1one
Copy link
Contributor

@air1one air1one commented Jun 24, 2020

Summary

initializeActiveDelegates was using a weird logic by using previous round, when only thing needed is current round.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link

codecov bot commented Jun 24, 2020

Codecov Report

Merging #3827 into develop will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3827      +/-   ##
===========================================
- Coverage    91.87%   91.86%   -0.01%     
===========================================
  Files          620      620              
  Lines        14768    14767       -1     
  Branches      1842     1842              
===========================================
- Hits         13568    13566       -2     
  Misses         939      939              
- Partials       261      262       +1     
Flag Coverage Δ
#functional 6.10% <0.00%> (+<0.01%) ⬆️
#integration 9.60% <0.00%> (+<0.01%) ⬆️
#unit 89.92% <100.00%> (-0.01%) ⬇️
Impacted Files Coverage Δ
packages/core-database/src/database-service.ts 97.24% <100.00%> (-0.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d64939...27943b4. Read the comment docs.

@air1one air1one changed the title fix(core-database): restoreCurrentRound shouldn't revert the round fix(core-database): initializeActiveDelegates just use current round Jun 24, 2020
@faustbrian faustbrian merged commit 7fa7af2 into develop Jun 25, 2020
@ghost ghost deleted the fix/core-database/restoreCurrentRound branch June 25, 2020 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants