fix(core-state): remove state=blockchain tag from block state

[rainydio]

Summary

Tags got mixed. BlockState was referenced with state=clone, but it itself was using wallet repository with state=blockchain. There are legit cases where one would need access to both wallet repositories. I will try to find a way to make it more difficult to misuse them.

Gonna start on #3798 and replace tags with child containers. So that blockchain wallet repository is default root one. Temp and copy-on-write wallet repositories has to be explicitly created through factory while being in blockchain context. Attempting to get blockchain wallet repository will also require explicit function call that is available only in temp and copy-on-write contexts.

So that one can't mix them by accident, but can mix them explicitly only in specific known cases.

Checklist

• Tests
• Ready to be merged

[codecov]

Codecov Report

Merging #3828 into develop will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #3828   +/-   ##
========================================
  Coverage    91.87%   91.88%           
========================================
  Files          620      620           
  Lines        14768    14768           
  Branches      1842     1842           
========================================
+ Hits         13568    13569    +1     
  Misses         939      939           
+ Partials       261      260    -1     

Flag	Coverage Δ
#functional	6.10% <ø> (ø)
#integration	9.60% <ø> (ø)
#unit	89.93% <ø> (+<0.01%)	⬆️

Impacted Files	Coverage Δ
packages/core-state/src/block-state.ts	100.00% <ø> (ø)
packages/core-p2p/src/network-monitor.ts	98.05% <0.00%> (+0.38%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e369b1...6aaa934. Read the comment docs.