Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-magistrate-transactions): entity handler bootstrap method, fetch transactions using asset type/subType as number #3852

Merged
merged 11 commits into from
Jul 2, 2020

Conversation

air1one
Copy link
Contributor

@air1one air1one commented Jun 29, 2020

Entity handler bootstrap method was fetching transactions using asset type/subType as string, resulting in no transaction fetched at all.

Also refactored htlc handlers to remove htlc attribute when there is no more lock for the wallet.

Added state builder run() test to each functional test to check that it would rebuild the same wallets state that was built from running the functional tests.

@codecov
Copy link

codecov bot commented Jun 29, 2020

Codecov Report

Merging #3852 into develop will increase coverage by 79.34%.
The diff coverage is 70.83%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #3852       +/-   ##
============================================
+ Coverage    12.83%   92.17%   +79.34%     
============================================
  Files          620      620               
  Lines        14840    14850       +10     
  Branches      1842     1844        +2     
============================================
+ Hits          1904    13688    +11784     
+ Misses       12823      948    -11875     
- Partials       113      214      +101     
Flag Coverage Δ
#functional 6.47% <8.33%> (+0.35%) ⬆️
#integration 9.56% <4.16%> (+<0.01%) ⬆️
#unit 90.59% <70.83%> (?)
Impacted Files Coverage Δ
...ore-magistrate-transactions/src/handlers/entity.ts 59.57% <0.00%> (+59.57%) ⬆️
...s/core-transactions/src/handlers/two/htlc-claim.ts 91.83% <77.77%> (+91.83%) ⬆️
.../core-transactions/src/handlers/two/htlc-refund.ts 89.41% <77.77%> (+89.41%) ⬆️
packages/core-state/src/state-builder.ts 100.00% <100.00%> (+100.00%) ⬆️
...e-test-framework/src/internal/wallet-attributes.ts 100.00% <100.00%> (ø)
...es/core-transactions/src/handlers/two/htlc-lock.ts 96.92% <100.00%> (+96.92%) ⬆️
packages/core-p2p/src/hapi-nes/client.ts 2.83% <0.00%> (+2.83%) ⬆️
packages/core-p2p/src/hapi-nes/socket.ts 2.89% <0.00%> (+2.89%) ⬆️
packages/core-p2p/src/hapi-nes/listener.ts 3.93% <0.00%> (+3.93%) ⬆️
...ore-test-framework/src/app/generators/generator.ts 100.00% <0.00%> (+5.88%) ⬆️
... and 561 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f041b3...4218726. Read the comment docs.

@air1one air1one changed the title test(functional): add state builder test to each functional test fix(core-magistrate-transactions): entity handler bootstrap method, fetch transactions using asset type/subType as number Jul 2, 2020
@air1one air1one requested a review from rainydio July 2, 2020 13:08
@faustbrian faustbrian merged commit 4031a51 into develop Jul 2, 2020
@ghost ghost deleted the test/functional/state-builder branch July 2, 2020 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants