Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-state): remove unnecessary assertion check to enable devnet sync #3885

Merged
merged 2 commits into from
Jul 9, 2020

Conversation

bertiespell
Copy link
Contributor

Summary

This removes an assertion check inside block-state.ts which was causing problems with devnet sync. The behaviour was recently added and can therefore be removed. Change supports #3882.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #3885 into develop will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3885   +/-   ##
========================================
  Coverage    97.61%   97.61%           
========================================
  Files          618      618           
  Lines        14430    14433    +3     
  Branches      1726     1725    -1     
========================================
+ Hits         14086    14089    +3     
  Misses         155      155           
  Partials       189      189           
Flag Coverage Δ
#functional 6.76% <0.00%> (-0.01%) ⬇️
#integration 9.87% <0.00%> (-0.01%) ⬇️
#unit 95.89% <100.00%> (+<0.01%) ⬆️
Impacted Files Coverage Δ
packages/core-state/src/block-state.ts 100.00% <100.00%> (ø)
packages/core-p2p/src/network-monitor.ts 99.62% <0.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 110ada8...dd9b754. Read the comment docs.

@air1one air1one merged commit 381e9c7 into develop Jul 9, 2020
@ghost ghost deleted the fix/block-state-assertion branch July 9, 2020 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants