Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-p2p): uses new Promise instead Promise.race #3886

Merged
merged 1 commit into from
Jul 9, 2020

Conversation

sebastijankuzner
Copy link
Contributor

Summary

This PR solves #3881

Checklist

  • Tests
  • Ready to be merged

@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #3886 into develop will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3886   +/-   ##
========================================
  Coverage    97.61%   97.61%           
========================================
  Files          617      618    +1     
  Lines        14411    14437   +26     
  Branches      1723     1727    +4     
========================================
+ Hits         14067    14093   +26     
  Misses         155      155           
  Partials       189      189           
Flag Coverage Δ
#functional 6.76% <0.00%> (+0.07%) ⬆️
#integration 9.87% <0.00%> (-0.02%) ⬇️
#unit 95.89% <100.00%> (-0.07%) ⬇️
Impacted Files Coverage Δ
packages/core-p2p/src/network-monitor.ts 99.62% <100.00%> (+0.01%) ⬆️
packages/core-database/src/models/transaction.ts 100.00% <0.00%> (ø)
packages/core-test-framework/src/utils/mapper.ts 100.00% <0.00%> (ø)
...es/core-snapshots/src/codecs/message-pack-codec.ts 100.00% <0.00%> (ø)
...0-add-block-height-column-to-transactions-table.ts 100.00% <0.00%> (ø)
...e-database/src/repositories/abstract-repository.ts 96.66% <0.00%> (+0.51%) ⬆️
packages/core-database/src/model-converter.ts 57.14% <0.00%> (+1.58%) ⬆️
...ackages/core-database/src/block-history-service.ts 56.41% <0.00%> (+2.35%) ⬆️
...s/core-database/src/transaction-history-service.ts 61.90% <0.00%> (+2.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d91aeb...d1ed400. Read the comment docs.

@air1one air1one merged commit 915263a into develop Jul 9, 2020
@ghost ghost deleted the fix/core-p2p/multipleResolvers branch July 9, 2020 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants