Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core-database): blocksInCurrentRound and forgingDelegates are arrays #3902

Merged
merged 3 commits into from
Jul 21, 2020

Conversation

sebastijankuzner
Copy link
Contributor

Summary

This PR set blocksInCurrentRound and forgingDelegates as array and remove possible undefined value. This fixes runtime errors when setting length value to undefined array.

Checklist

  • Ready to be merged

@sebastijankuzner sebastijankuzner force-pushed the fix/core-database/remove-undefined-arrays branch from 3216590 to bc68b0d Compare July 21, 2020 14:44
@codecov
Copy link

codecov bot commented Jul 21, 2020

Codecov Report

Merging #3902 into develop will increase coverage by 82.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #3902       +/-   ##
============================================
+ Coverage    13.68%   95.81%   +82.13%     
============================================
  Files          628      628               
  Lines        14528    14526        -2     
  Branches      1728     1727        -1     
============================================
+ Hits          1988    13918    +11930     
+ Misses       12425      419    -12006     
- Partials       115      189       +74     
Flag Coverage Δ
#functional ?
#integration 9.83% <0.00%> (+<0.01%) ⬆️
#unit 95.75% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core-database/src/database-service.ts 97.22% <100.00%> (+97.22%) ⬆️
...rc/migrations/20190307000000-drop-wallets-table.ts 0.00% <0.00%> (-100.00%) ⬇️
...c/migrations/20180305200000-create-rounds-table.ts 0.00% <0.00%> (-100.00%) ⬇️
...c/migrations/20180305300000-create-blocks-table.ts 0.00% <0.00%> (-100.00%) ⬇️
.../migrations/20180305100000-create-wallets-table.ts 0.00% <0.00%> (-100.00%) ⬇️
...igrations/20190626000000-enforce-chained-blocks.ts 0.00% <0.00%> (-100.00%) ⬇️
...rations/20191003000000-migrate-vendor-field-hex.ts 0.00% <0.00%> (-100.00%) ⬇️
...ations/20180305400000-create-transactions-table.ts 0.00% <0.00%> (-100.00%) ⬇️
.../20190718000000-check_previous_block-add-schema.ts 0.00% <0.00%> (-100.00%) ⬇️
...20190619000000-drop-id-column-from-rounds-table.ts 0.00% <0.00%> (-100.00%) ⬇️
... and 587 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd29f85...bc68b0d. Read the comment docs.

@air1one air1one merged commit 50ce984 into develop Jul 21, 2020
@ghost ghost deleted the fix/core-database/remove-undefined-arrays branch July 21, 2020 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants