Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core-p2p): add 3.0.0 alpha channel to valid peer versions #3924

Merged
merged 2 commits into from
Aug 3, 2020

Conversation

air1one
Copy link
Contributor

@air1one air1one commented Aug 3, 2020

Summary

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #3924 into develop will decrease coverage by 1.76%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3924      +/-   ##
===========================================
- Coverage    97.56%   95.80%   -1.77%     
===========================================
  Files          629      629              
  Lines        14535    14535              
  Branches      1728     1728              
===========================================
- Hits         14181    13925     -256     
- Misses         165      421     +256     
  Partials       189      189              
Flag Coverage Δ
#functional ?
#integration 9.83% <ø> (ø)
#unit 95.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/migrations/20190307000000-drop-wallets-table.ts 0.00% <0.00%> (-100.00%) ⬇️
...c/migrations/20180305200000-create-rounds-table.ts 0.00% <0.00%> (-100.00%) ⬇️
...c/migrations/20180305300000-create-blocks-table.ts 0.00% <0.00%> (-100.00%) ⬇️
.../migrations/20180305100000-create-wallets-table.ts 0.00% <0.00%> (-100.00%) ⬇️
...igrations/20190626000000-enforce-chained-blocks.ts 0.00% <0.00%> (-100.00%) ⬇️
...rations/20191003000000-migrate-vendor-field-hex.ts 0.00% <0.00%> (-100.00%) ⬇️
...ations/20180305400000-create-transactions-table.ts 0.00% <0.00%> (-100.00%) ⬇️
.../20190718000000-check_previous_block-add-schema.ts 0.00% <0.00%> (-100.00%) ⬇️
...20190619000000-drop-id-column-from-rounds-table.ts 0.00% <0.00%> (-100.00%) ⬇️
...81204200000-add-timestamp-index-to-blocks-table.ts 0.00% <0.00%> (-100.00%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fa24f6...dd7fb0b. Read the comment docs.

faustbrian
faustbrian previously approved these changes Aug 3, 2020
@faustbrian faustbrian merged commit f2da0bd into develop Aug 3, 2020
@ghost ghost deleted the chore/peer-alpha-version branch August 3, 2020 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants