Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core-p2p): implement HEAD HTTP request for ping #3926

Merged
merged 1 commit into from
Aug 3, 2020

Conversation

sebastijankuzner
Copy link
Contributor

Summary

This PR solves #3920.

All @arkecosystem/utils dependencies has been updated to version 1.2.0.

P2P Ping method is using HEAD instead GET HTTP request.

Checklist

  • Tests
  • Ready to be merged

@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #3926 into develop will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3926   +/-   ##
========================================
  Coverage    97.56%   97.56%           
========================================
  Files          629      629           
  Lines        14535    14535           
  Branches      1728     1728           
========================================
  Hits         14181    14181           
  Misses         165      165           
  Partials       189      189           
Flag Coverage Δ
#functional 6.82% <0.00%> (ø)
#integration 9.83% <0.00%> (ø)
#unit 95.74% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core-p2p/src/peer-communicator.ts 99.18% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2da0bd...9161877. Read the comment docs.

@air1one air1one merged commit fcbe909 into develop Aug 3, 2020
@ghost ghost deleted the chore/core-p2p/head-for-ping branch August 3, 2020 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants