Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(core-magistrate-crypto): increase test coverage to 100% #3983

Merged
merged 2 commits into from Aug 28, 2020

Conversation

sebastijankuzner
Copy link
Contributor

@sebastijankuzner sebastijankuzner commented Aug 28, 2020

Summary

Solves #3977

Increase core-magistrate-transactions to 100 %.

Checklist

  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link

codecov bot commented Aug 28, 2020

Codecov Report

Merging #3983 into develop will increase coverage by 1.86%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3983      +/-   ##
===========================================
+ Coverage    96.24%   98.11%   +1.86%     
===========================================
  Files          631      631              
  Lines        14577    14577              
  Branches      1729     1729              
===========================================
+ Hits         14030    14302     +272     
+ Misses         387      131     -256     
+ Partials       160      144      -16     
Flag Coverage Δ
#functional 6.80% <ø> (?)
#integration 9.88% <ø> (ø)
#unit 96.28% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core-p2p/src/network-monitor.ts 99.62% <0.00%> (-0.38%) ⬇️
...rypto/src/transactions/bridgechain-registration.ts 100.00% <0.00%> (+1.09%) ⬆️
...e-crypto/src/transactions/business-registration.ts 100.00% <0.00%> (+1.88%) ⬆️
...re-test-framework/src/utils/transaction-factory.ts 98.86% <0.00%> (+2.84%) ⬆️
...crypto/src/transactions/bridgechain-resignation.ts 100.00% <0.00%> (+5.00%) ⬆️
...rate-crypto/src/transactions/bridgechain-update.ts 100.00% <0.00%> (+5.15%) ⬆️
...-magistrate-crypto/src/builders/business-update.ts 100.00% <0.00%> (+5.26%) ⬆️
...gistrate-crypto/src/builders/bridgechain-update.ts 100.00% <0.00%> (+5.26%) ⬆️
...trate-crypto/src/builders/business-registration.ts 100.00% <0.00%> (+5.26%) ⬆️
...ate-crypto/src/builders/bridgechain-resignation.ts 100.00% <0.00%> (+5.26%) ⬆️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36878fc...e5ffec3. Read the comment docs.

@faustbrian faustbrian merged commit 4167457 into develop Aug 28, 2020
@ghost ghost deleted the test/core-magistrate-crypto/increate-coverage branch August 28, 2020 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants