-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(core-state): autoIndex option #3985
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3985 +/- ##
===========================================
+ Coverage 96.24% 98.00% +1.75%
===========================================
Files 631 631
Lines 14577 14578 +1
Branches 1729 1729
===========================================
+ Hits 14030 14287 +257
+ Misses 387 131 -256
Partials 160 160
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All in all it makes perfect sense. If index isn't complicated (most cases), then you can rely on automatic re-indexing. Otherwise you'll have to call getIndex
and do everything manually and carefully.
Summary
Implements autoIndex option on indexes. When autoIndex is enabled, WalletRepository.index(wallet) method will remove all known index entries by wallet and will reindex wallet, otherwise developer is responsible to manually use index, set or delete methods directly on index.
Disabling autoIndex option is useful in cases when index hold a lot of entries for the wallet and manual control over index will increase node performance.
Checklist