Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(core-transactions): increase coverage to 100% #3992

Merged
merged 7 commits into from
Sep 3, 2020

Conversation

sebastijankuzner
Copy link
Contributor

@sebastijankuzner sebastijankuzner commented Sep 1, 2020

Summary

Solves #3979

Increase core-transactions to 100 %.

Checklist

  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #3992 into develop will increase coverage by 0.37%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3992      +/-   ##
===========================================
+ Coverage    98.12%   98.50%   +0.37%     
===========================================
  Files          631      631              
  Lines        14578    14576       -2     
  Branches      1729     1731       +2     
===========================================
+ Hits         14305    14358      +53     
+ Misses         130      128       -2     
+ Partials       143       90      -53     
Flag Coverage Δ
#functional 6.80% <0.00%> (+<0.01%) ⬆️
#integration 9.88% <0.00%> (+<0.01%) ⬆️
#unit 96.67% <100.00%> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...sactions/src/handlers/one/delegate-registration.ts 100.00% <ø> (+9.09%) ⬆️
...s/core-transactions/src/handlers/two/htlc-claim.ts 100.00% <ø> (+8.16%) ⬆️
.../src/handlers/one/second-signature-registration.ts 100.00% <100.00%> (+3.44%) ⬆️
.../core-transactions/src/handlers/two/htlc-refund.ts 100.00% <100.00%> (+10.58%) ⬆️
...ackages/core-transactions/src/handlers/two/ipfs.ts 100.00% <100.00%> (+13.95%) ⬆️
...es/core-transactions/src/handlers/two/htlc-lock.ts 100.00% <0.00%> (+3.07%) ⬆️
...core-transactions/src/handlers/handler-registry.ts 100.00% <0.00%> (+3.12%) ⬆️
...sactions/src/handlers/two/delegate-registration.ts 100.00% <0.00%> (+3.44%) ⬆️
...s/src/handlers/one/multi-signature-registration.ts 100.00% <0.00%> (+3.84%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 934d306...e815f96. Read the comment docs.

@faustbrian faustbrian merged commit 3fef590 into develop Sep 3, 2020
@ghost ghost deleted the test/core-transactions/increase-coverage branch September 3, 2020 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants