Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core-test-framework): resolve .env and app.json file path from package name #4006

Merged
merged 1 commit into from
Sep 7, 2020

Conversation

sebastijankuzner
Copy link
Contributor

@sebastijankuzner sebastijankuzner commented Sep 7, 2020

Summary

Use file path resolving based on package name rather than using relative structure used in packages/. Fixes problem which occur on booting sandbox.app when using published @arkecosystem/core-test-framework package.

Checklist

  • Ready to be merged

@codecov
Copy link

codecov bot commented Sep 7, 2020

Codecov Report

Merging #4006 into develop will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #4006   +/-   ##
========================================
  Coverage    98.49%   98.49%           
========================================
  Files          631      631           
  Lines        14583    14583           
  Branches      1732     1732           
========================================
  Hits         14363    14363           
  Misses         129      129           
  Partials        91       91           
Flag Coverage Δ
#functional 6.80% <100.00%> (ø)
#integration 9.88% <50.00%> (ø)
#unit 96.66% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ges/core-test-framework/src/app/generators/core.ts 96.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddca08f...5ac5f9a. Read the comment docs.

@faustbrian faustbrian changed the title chore(core-test-framework): resolve .env nad app.json file path from package name chore(core-test-framework): resolve .env and app.json file path from package name Sep 7, 2020
@air1one air1one merged commit c715c85 into develop Sep 7, 2020
@ghost ghost deleted the fix/core-test-framework/import-from-package branch September 7, 2020 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants