Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(core-test-framework): increase test coverage to 100% #4021

Merged
merged 9 commits into from
Sep 11, 2020

Conversation

sebastijankuzner
Copy link
Contributor

@sebastijankuzner sebastijankuzner commented Sep 10, 2020

Summary

Solves #4013

Increase core-test-framework coverage to 100 %.

Checklist

  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link

codecov bot commented Sep 10, 2020

Codecov Report

Merging #4021 into develop will increase coverage by 0.31%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4021      +/-   ##
===========================================
+ Coverage    98.47%   98.78%   +0.31%     
===========================================
  Files          638      638              
  Lines        14806    14793      -13     
  Branches      1748     1736      -12     
===========================================
+ Hits         14580    14614      +34     
+ Misses         130      104      -26     
+ Partials        96       75      -21     
Flag Coverage Δ
#functional 6.95% <54.54%> (+0.01%) ⬆️
#integration 11.54% <66.66%> (+0.02%) ⬆️
#unit 96.70% <100.00%> (+0.90%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...test-framework/src/matchers/functional/rejected.ts 100.00% <ø> (+9.52%) ⬆️
...-framework/src/matchers/functional/vote-balance.ts 100.00% <ø> (+10.00%) ⬆️
...core-test-framework/src/utils/api-inject-client.ts 100.00% <ø> (+7.40%) ⬆️
packages/core-test-framework/src/utils/generic.ts 100.00% <ø> (+10.34%) ⬆️
...ges/core-test-framework/src/app/generators/core.ts 100.00% <100.00%> (+3.33%) ⬆️
...re-test-framework/src/factories/factories/block.ts 100.00% <100.00%> (+7.40%) ⬆️
...t-framework/src/matchers/functional/unconfirmed.ts 100.00% <100.00%> (+84.61%) ⬆️
...s/core-test-framework/src/utils/api-http-client.ts 100.00% <100.00%> (+21.42%) ⬆️
packages/core-test-framework/src/utils/api.ts 100.00% <100.00%> (+2.58%) ⬆️
...re-test-framework/src/utils/transaction-factory.ts 100.00% <100.00%> (+1.13%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e64ef6...8278a34. Read the comment docs.

@air1one air1one merged commit 05d59a9 into develop Sep 11, 2020
@ghost ghost deleted the test/core-test-framework/increase-coverage branch September 11, 2020 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants