-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(core-test-framework): increase test coverage to 100% #4021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastijankuzner
requested review from
air1one,
faustbrian and
kristjank
as code owners
September 10, 2020 15:06
ghost
added
Complexity: Undetermined
labels
Sep 10, 2020
# Conflicts: # packages/core-test-framework/src/utils/api.ts
Codecov Report
@@ Coverage Diff @@
## develop #4021 +/- ##
===========================================
+ Coverage 98.47% 98.78% +0.31%
===========================================
Files 638 638
Lines 14806 14793 -13
Branches 1748 1736 -12
===========================================
+ Hits 14580 14614 +34
+ Misses 130 104 -26
+ Partials 96 75 -21
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…ansaction signing
air1one
approved these changes
Sep 11, 2020
ghost
deleted the
test/core-test-framework/increase-coverage
branch
September 11, 2020 14:34
ghost
mentioned this pull request
Sep 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Solves #4013
Increase core-test-framework coverage to 100 %.
Checklist