Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core-state): cloneWallet method in wallet-repository #4027

Merged
merged 2 commits into from
Sep 16, 2020

Conversation

sebastijankuzner
Copy link
Contributor

@sebastijankuzner sebastijankuzner commented Sep 14, 2020

Summary

Implement cloneWallet method on main wallet-repository which clone wallet from passed wallet-repository. Clone method will clone wallet by each index and will copy all index entries.

Checklist

  • Ready to be merged

@codecov
Copy link

codecov bot commented Sep 14, 2020

Codecov Report

Merging #4027 into develop will decrease coverage by 0.00%.
The diff coverage is 91.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4027      +/-   ##
===========================================
- Coverage    98.79%   98.79%   -0.01%     
===========================================
  Files          638      638              
  Lines        14798    14797       -1     
  Branches      1739     1739              
===========================================
- Hits         14620    14619       -1     
  Misses         104      104              
  Partials        74       74              
Flag Coverage Δ
#functional 6.95% <0.00%> (+<0.01%) ⬆️
#integration 11.54% <0.00%> (+<0.01%) ⬆️
#unit 96.70% <91.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ate/src/wallets/wallet-repository-copy-on-write.ts 88.23% <66.66%> (-3.07%) ⬇️
.../core-state/src/wallets/wallet-repository-clone.ts 100.00% <100.00%> (ø)
...ckages/core-state/src/wallets/wallet-repository.ts 94.02% <100.00%> (+0.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 956d629...c32e176. Read the comment docs.

rainydio
rainydio previously approved these changes Sep 14, 2020
@air1one air1one merged commit d0775fd into develop Sep 16, 2020
@ghost ghost deleted the chore/core-state/cloneWallet branch September 16, 2020 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants