-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: slot, round and forgingInfo calculation for dynamic block times #4034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastijankuzner
requested review from
air1one,
faustbrian and
kristjank
as code owners
September 15, 2020 15:11
ghost
added
Complexity: High
labels
Sep 15, 2020
Codecov Report
@@ Coverage Diff @@
## develop #4034 +/- ##
============================================
- Coverage 98.79% 13.32% -85.48%
============================================
Files 638 715 +77
Lines 14798 17110 +2312
Branches 1739 2082 +343
============================================
- Hits 14620 2280 -12340
- Misses 104 14722 +14618
- Partials 74 108 +34
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
sebastijankuzner
changed the title
fix(core-kernel): fix calculate-forging-info
fix: slot and round calculation
Sep 17, 2020
sebastijankuzner
changed the title
fix: slot and round calculation
fix: slot, round and forgingInfo calculation for dynamic block times
Sep 17, 2020
air1one
approved these changes
Sep 18, 2020
ghost
deleted the
chore/core-kernel/round-updates
branch
September 18, 2020 09:34
ghost
mentioned this pull request
Sep 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes invalid handling of dynamic blockTime in milestones. Affected are Slots from packages/crypto and calculate-forging-info from packages/core-kernel.
Fixes now calculate valid data for static and dynamic blockTime and are supported by valid test.
Because of similar logic logic there is also refactored core-kernel/round-calculator.
Checklist