Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-api): remove search endpoints #4067

Merged
merged 4 commits into from
Sep 29, 2020

Conversation

air1one
Copy link
Contributor

@air1one air1one commented Sep 28, 2020

Summary

Resolves #4063

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link

codecov bot commented Sep 28, 2020

Codecov Report

Merging #4067 into develop will increase coverage by 3.15%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4067      +/-   ##
===========================================
+ Coverage    10.19%   13.35%   +3.15%     
===========================================
  Files          715      715              
  Lines        17227    17188      -39     
  Branches      2089     2087       -2     
===========================================
+ Hits          1757     2296     +539     
+ Misses       15372    14786     -586     
- Partials        98      106       +8     
Flag Coverage Δ
#functional 5.99% <ø> (?)
#integration 10.02% <ø> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core-api/src/controllers/blocks.ts 79.54% <ø> (+4.03%) ⬆️
packages/core-api/src/controllers/delegates.ts 67.34% <ø> (-2.47%) ⬇️
packages/core-api/src/controllers/locks.ts 80.00% <ø> (+11.03%) ⬆️
packages/core-api/src/controllers/transactions.ts 81.25% <ø> (+1.47%) ⬆️
packages/core-api/src/controllers/wallets.ts 61.11% <ø> (-1.66%) ⬇️
packages/core-api/src/resources-new/delegate.ts 100.00% <ø> (ø)
packages/core-api/src/resources-new/lock.ts 100.00% <ø> (ø)
packages/core-api/src/resources-new/wallet.ts 100.00% <ø> (ø)
packages/core-api/src/routes/blocks.ts 100.00% <ø> (ø)
packages/core-api/src/routes/delegates.ts 93.33% <ø> (-0.79%) ⬇️
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15521b7...64edb47. Read the comment docs.

@faustbrian faustbrian changed the title chore(core-api): remove /search from api chore(core-api): remove search endpoints Sep 28, 2020
Brian Faust added 2 commits September 28, 2020 19:39
@faustbrian faustbrian changed the title chore(core-api): remove search endpoints refactor(core-api): remove search endpoints Sep 29, 2020
@faustbrian faustbrian merged commit deb2cd7 into develop Sep 29, 2020
@ghost ghost deleted the chore/api-remove-search branch September 29, 2020 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants