-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ESP32 Tests #157
Fix ESP32 Tests #157
Conversation
ESP32 test builds were not passing and the tests themselves were not being compiled into the firmware binary. Added missing ignore filters to ignore desktop libraries for building PIO and desktop targets in the same source tree.
Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on. If no reviewer appears after a week, a reminder will be sent out. |
Codecov Report
@@ Coverage Diff @@
## develop #157 +/- ##
========================================
Coverage 97.92% 97.92%
========================================
Files 8 8
Lines 385 385
========================================
Hits 377 377
Misses 8 8 Continue to review full report at Codecov.
|
A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution! |
Your pull request has been merged but was not assigned a bounty tier. A maintainer will assign a bounty tier to this pull request in the next few days. |
Your pull request has been merged and marked as tier 4. It will earn you $20 USD. |
Summary
ESP32 test builds were not passing and the tests themselves were not
being compiled into the firmware binary. Added missing ignore filters
to ignore desktop libraries for building PIO and desktop targets in the
same source tree.
Checklist