This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
feat: allow expanding and collapsing the wallet/contact sidebar #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-a-m-l
added
Status: Needs Review
Codecov Report
@@ Coverage Diff @@
## develop #1015 +/- ##
===========================================
- Coverage 38.55% 38.44% -0.12%
===========================================
Files 200 200
Lines 4972 4979 +7
Branches 975 981 +6
===========================================
- Hits 1917 1914 -3
- Misses 2940 2949 +9
- Partials 115 116 +1
Continue to review full report at Codecov.
|
|
I think it looks good 👌 I get a weird "bug" where the bottom border of each wallet goes white when it's expanding though. Regarding the filter stuff, I think it's worth either removing it all from this PR and adding it all together in its own PR, or adding the filter stuff to this PR. I think it's best to have commits/PRs merged as production ready, whereas this one technically wouldn't be since the filter button isn't ready yet. A third option could be that once this PR is approved, don't merge to develop but branch off this branch and do the filter stuff. Then it can be merged into here and then all merged to develop. This means they can be both reviewed independently without either getting too large |
|
@alexbarnsley I think it's a good idea. I've removed the filters part, but I'd like to resume it after this PR is merged. About that "bug", I don't see any weird thing, but, by your explanation, I guess that it's because the bottom border is only applied on the expanded version. |
luciorubeens
previously approved these changes
Jan 25, 2019
luciorubeens
approved these changes
Jan 25, 2019
|
@j-a-m-l I've fixed conflicts and approved, now you can merge to your branch. |
|
Thanks @luciorubeens |
|
How about
The framerate isn't ideal but you get the idea. |
|
@dated I like the idea. If you want to create a PR, I'll review it. If not I'll implement it myself |
luciorubeens
added a commit
that referenced
this pull request
Jan 29, 2019
* improvement: make wallet heading name more visible in dark mode (#996) * fix: correctly handle zero balance on wallet heading info (#1000) * fix: conditional alignment of items (#1005) * improvement: adjust announcement section to fit new design (#982) * improvement: new instructions section for wallet import/new and network overview page (#1003) * improvement: new instructions section for wallet import page * improvement: new instructions section for wallet new page * improvement: new instructions section for network overview page * refactor: new wallet selection styles and ui (#1006) * fix: do not shake when generating new wallets (#1008) * refactor: success/error colors and delay on clipboard button tooltip (#1010) * refactor: success/error colors and delay on clipboard button tooltip * misc: use tailwind classes Co-authored-by: Lúcio Rubens <luciorubeens@gmail.com> * docs: fix and improve the instructions of how to translate the app (#1004) * feat: adapt the contact creation page to new style (#1012) * refactor: how to infer which background to use on contact new page * test: adapt the tests * misc: include the new background for the contact creation page * feat: add new design to the contact creation page * refactor: rename contact creation background from `purse.svg` to `wallet.svg` * refactor: remove unnecessary delegate api calls (#995) * refactor: differentiate between wallet and contact rename (#988) * feat/fix: validation on sign/verify modals & signed messages alignment (#1014) * feat: validation on sign/verify modals * misc: add :focus color to input icons * fix: signed message alignment * refactor: remove nested if branch * fix: json validation * misc: update example json format * feat: different network name style & add ledger flags (#991) * feat: different style for names provided by the network * fix: show only ledger wallet if address is also watch only wallet * fix: correct sorting by name if numerical * refactor: ledger badge in wallet sidebar * fix: show wallet/contact name * feat: make whole wallet/contact card clickable * feat: network name tooltip on wallet/contact grid view * fix: create contact card alignment * misc: set hover styles to wallet/contact name on card * fix: network name tooltip condition * misc: remove wallet/contact name hover classes * misc: stop click propagation on card name and balance * misc: ledger badge styles and tooltip * fix: sidebar truncation length if ledger * docs: remove the beta warning and collpase list of commands (#1020) * feat: allow expanding and collapsing the wallet/contact sidebar (#1015) * fix: inconsistencies between network versions (#1016) * fix: transaction fees for v1 networks * chore: update @arkecosystem/client * fix: store isHttps for current peer in client * fix: broadcast tx if no other peers * refactor: rename method to get peer api version * fix: check config for core-api excluding prefix(es) * fix: getters return empty array if no peers * fix: check peer if v2 to update props, not network * refactor: get /config from wallet to remove header * fix: only swap ports on refresh if not already * test: fix by passing peers in as v2 peers not v1 * fix: set tx timestamp based on network epoch * fix: sending to single peer if broadcast off * fix: use 3s timeout when broadcasting to peers * fix: add forged to delegate model (#1017) * fix: add forged to delegate model * test: adjust delegate fixtures and tests * feat: persistent sorting in wallet/contact table (#1002) * feat: persistent sorting in wallet/contact table * test: add getter & setter tests * refactor: replace the profile avatars with a new component `ProfileAvatar` (#1019) * refactor: extract the `ProfileAvatar` component from the main sidemenu * refactor: `ProfileAll` to include `ProfileAvatar` * fix: avoid breaking the layout and displacing links when the profile balance has 8 decimals * refactor: extract the `ProfileAvatar` component from the main sidemenu * refactor: `ProfileAll` to include `ProfileAvatar` * fix: avoid breaking the layout and displacing links when the profile balance has 8 decimals * refactor: use the `ProfileAvatar` on the wallets page * refactor: use the `ProfileAvatar` on the remove profile confirmation * fix: adjust the position of the avatar on wallet page * fix: importing of profile avatar selection modal component (#1031) * feat: adapt the contacts page to new design (#1007) * feat: show contact balance on list layout * feat: adapt the contacts page to the new style * refactor: increase padding * fix: increase the font weight of the "i" badge on contact placeholder * feat: show contact balance on list layout * feat: adapt the contacts page to the new style * refactor: increase padding * fix: increase the font weight of the "i" badge on contact placeholder Co-authored-by: Alex Barnsley <8069294+alexbarnsley@users.noreply.github.com> Co-authored-by: Lúcio Rubens <luciorubeens@gmail.com> * refactor: invert identicon hover behaviour (#1025) * feat: add sidebar animation (#1021) * feat: add sidebar animation * misc: speed up transition * fix: errors during and after removing profiles (#1033) * fix: do not fail on the profile creation page when removing the last profile * fix: do not fail at start due not having an active profile * test: the profile removal confirmation * fix: avoid errors when removing a profile * feat: loading screen when broadcasting to many peers (#1023) * fix: don't modify modal loader state * chore: correct ModalLoder name * feat: ModalLoader emit closed * feat: show loader on broadcast to many peers * fix: timeout when getting peer config * feat: allow close warning message override * refactor: update close message for slow broadcasting Co-authored-by: Juan <j-a-m-l@users.noreply.github.com> * fix: allow selecting the balance on the wallet page heading (#994) * fix: show "Unvote" action on delegate tab when using Ledger (#1032) * fix: do not fail when voting with Ledger * fix: show the "Unvote" button at the bottom of the delegate tab when using Ledger wallets * refactor: new selection design for the network overview (#1037) * change instructions image * refactor: new selection design for the network overview * fix: broadcasting modal not closing on unvote (#1038) * chore: update @arkecosystem/client (#1036) * feat: use network static fees as max (#1022) * chore: update @arkecosystem/client to 0.1.19 * feat: client method to fetch static fees * feat: tx store method to update static fees * feat: update static fees on peer change * feat: inputFee component use static if available * test: fix failing * test: api client service fetchStaticFees * test: transaction store with static fees * docs: jsdoc for new methods * refactor: store fees against network, not profile * test: refactor to use network not profile * fix: update fees when changing peer or custom * chore: update wallet import and networks pages headings (#1039) * fix: numbers with colon (",") and other formats on the send transfer inputs (#1009) * chore: bump to 2.2.1 (#1040)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This feature is the first part of changes that add more functionality to the wallet sidebar. This PR is focused solely on expanding / collapsing the sidebar.
Types of changes
Checklist