This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
Disable screenshot protection setting if the platform is linux #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spresnal
suggested changes
Oct 17, 2017
main.js
Outdated
| @@ -177,6 +177,10 @@ function createWindow () { | |||
| } | |||
| ]; | |||
|
|
|||
| if (process.platform === "linux") { | |||
| template[0].submenu[2] = { label: "Screenshot Protection Not Available On Linux", enabled: false}; | |||
| } | |||
There was a problem hiding this comment.
I don't think this is the best way to go about it -- specifically i'm talking about referencing template element 0 & submenu element 2. If a submenu gets added before the screenshot label then this will cause unintended effects.
Would be preferred to call a method from line 153 that gets the appropriate screenshot label
|
Good call, thank you @spresnal . I created a function to get the proper label. One issue though is that template[0].submenu[2] is still used in updateScreenshotProtectionItem(). |
|
+5 👍🏻 |
alexbarnsley
pushed a commit
that referenced
this pull request
Dec 3, 2018
* feat: blur modal backdrop * fix: portal -> modal
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because Electron doesn't have content protection on Linux, I think the screenshot protection settings button should be disabled on Linux. Users shouldn't be given an option that they may think provides some security if the option actually does nothing, it's misleading.
Resolves #336