This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
Moved splashscreen css to css file #353
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…een image to the images folder
spresnal
reviewed
Oct 19, 2017
client/app/assets/app.css
Outdated
| @@ -6,6 +6,8 @@ body { | |||
| margin: 0px; | |||
| padding: 0px; | |||
| background-position: center; | |||
| background-color: #000; | |||
| border-radius: 10px; | |||
There was a problem hiding this comment.
The border-radius wasn't being applied to the body before. Was this an intended change?
|
can you fix the conflict? |
|
Should be fixed now! |
|
Hmm I tried it and we can't do this because the css is loaded before the splash screen.. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splashscreen css is currently in the html file, to clean up code decided to move it to the app.css file.
I also moved splashscreen.png to the images folder.